Conversation
Debug code removed from HyperbolicVoronoiGraphicsItem.h. Systematically failing assertion commented out in Hyperbolic_Delaunay_triangulation_traits_2.h.
|
@MoniqueTeillaud Can you or one of your students have a look at that small contribution? It is announced as a bug-fix, but I am not sure if it is correct. |
|
@lrineau commented on Sep 4, 2019, 11:27 AM GMT+2:
@MoniqueTeillaud, that contribution is now more that three months old. |
|
I currently have 0 student and I was assigned only one month ago. We could have discussed this during the CGAL meeting two weeks ago, it would have been more efficient.
|
|
Hello @lrineau, @MoniqueTeillaud , I will have a look as soon as possible! I will get back to you once I have had the chance to review the modifications. |
| // delete | ||
| QPen temp = painter->pen(); | ||
| QPen old = temp; | ||
| temp.setWidthF(0.01); | ||
| painter->setPen(temp); | ||
| // | ||
|
|
||
| for(typename DT::All_edges_iterator eit = dt->all_edges_begin(); | ||
| eit != dt->all_edges_end(); | ||
| eit++) | ||
| { | ||
| typename DT::Hyperbolic_segment s = dt->dual(*eit); | ||
| pos << s; | ||
| } | ||
|
|
||
| // delete | ||
| painter->setPen(old); |
There was a problem hiding this comment.
This should be OK, it's a part of the demo and it has no critical impact on the actual code.
imiordanov
left a comment
imiordanov
left a comment
There was a problem hiding this comment.
Cleaning up the debug code from the Qt interface is OK, no issues there.
However, I would like to investigate the failing assertion a bit more, before just commenting it out of the code. I'll try to find the time to debug as soon as possible.
| CGAL_triangulation_precondition((_gt.side_of_oriented_circle_2_object()(p, q, r,s) == ON_NEGATIVE_SIDE) && | ||
| (_gt.side_of_oriented_circle_2_object()(p, s, q, r) == ON_NEGATIVE_SIDE)); |
There was a problem hiding this comment.
This precondition asserts that the faces (p,q,r) does not contain s, and the face (p,s,q) does not contain r, which is satisfied if the two faces (p,q,r) and (p,s,q) are Delaunay. If the assertion is failing, I feel like more investigation is needed, instead of just commenting out the check altogether.
There was a problem hiding this comment.
Indeed, just commenting out is dangerous.
I am a bit surprised that, if the assertion is problematic, this has not been detected by the test-suite...
There was a problem hiding this comment.
@switzel Can you comment on why you removed that precondition?
MaelRL
added
the
Not yet approved
|
Closed due to inactivity |
6 participants
Summary of Changes
Debug code removed from HyperbolicVoronoiGraphicsItem.h.
Systematically failing assertion commented out in
Hyperbolic_Delaunay_triangulation_traits_2.h.
Release Management