fix check-dependencies (master)

[lrineau]

Summary of Changes

#4105, adapted to master

Release Management

• Affected package(s): Installation

[maxGimeno]

Travis detected differences in the dependencies. Are those what's expected from this PR ? In such case pleae correct them in the package_info files

Differences in TDS_2: Interval_support
Modular_arithmetic
Number_types have disappeared.
 Differences in Random_numbers: Random_numbers have disappeared.
 Differences in Geomview: Geomview have disappeared.

[lrineau]

@maxGimeno commented on Jul 24, 2019, 9:09 AM GMT+2:

Travis detected differences in the dependencies. Are those what's expected from this PR ? In such case pleae correct them in the package_info files

Differences in TDS_2: Interval_support
Modular_arithmetic
Number_types have disappeared.
 Differences in Random_numbers: Random_numbers have disappeared.
 Differences in Geomview: Geomview have disappeared.

Those are exactly the difference between running the dependency checking with CGAL_HEADER_ONLY set or not. I have committed 741b3ce so that Travis uses the default.

[lrineau]

cgal/Scripts/developer_scripts/cgal_check_dependencies.sh

Lines 39 to 54 in 741b3ce

	for pkg_path in $CGAL_ROOT/*
	do
	pkg=$(basename $pkg_path)
	if [ -f "$pkg_path/package_info/$pkg/dependencies" ]; then
	PKG_DIFF=$(grep -Fxv -f "$pkg_path/package_info/$pkg/dependencies.old" "$pkg_path/package_info/$pkg/dependencies" || true)
	if [ -n "$PKG_DIFF" ]; then
	TOTAL_RES="Differences in $pkg: $PKG_DIFF are new and not committed.\n $TOTAL_RES"
	fi
	PKG_DIFF=$(grep -Fxv -f "$pkg_path/package_info/$pkg/dependencies" "$pkg_path/package_info/$pkg/dependencies.old" || true)
	if [ -n "$PKG_DIFF" ]; then
	TOTAL_RES="Differences in $pkg: $PKG_DIFF have disappeared.\n $TOTAL_RES"
	fi
	if [ -f $pkg_path/package_info/$pkg/dependencies.old ]; then
	rm $pkg_path/package_info/$pkg/dependencies.old
	fi
	fi

I think we should enforce that the dependencies files are sorted, and use a plain diff instead of that complicated logic. What is more, the diff would help fix the issue, by using patch to apply the diff.

[lrineau]

@lrineau commented on Jul 24, 2019, 3:44 PM GMT+2:

cgal/Scripts/developer_scripts/cgal_check_dependencies.sh

Lines 39 to 54 in 741b3ce

	for pkg_path in $CGAL_ROOT/*
	do
	pkg=$(basename $pkg_path)
	if [ -f "$pkg_path/package_info/$pkg/dependencies" ]; then
	PKG_DIFF=$(grep -Fxv -f "$pkg_path/package_info/$pkg/dependencies.old" "$pkg_path/package_info/$pkg/dependencies" || true)
	if [ -n "$PKG_DIFF" ]; then
	TOTAL_RES="Differences in $pkg: $PKG_DIFF are new and not committed.\n $TOTAL_RES"
	fi
	PKG_DIFF=$(grep -Fxv -f "$pkg_path/package_info/$pkg/dependencies" "$pkg_path/package_info/$pkg/dependencies.old" || true)
	if [ -n "$PKG_DIFF" ]; then
	TOTAL_RES="Differences in $pkg: $PKG_DIFF have disappeared.\n $TOTAL_RES"
	fi
	if [ -f $pkg_path/package_info/$pkg/dependencies.old ]; then
	rm $pkg_path/package_info/$pkg/dependencies.old
	fi
	fi

I think we should enforce that the dependencies files are sorted, and use a plain diff instead of that complicated logic. What is more, the diff would help fix the issue, by using patch to apply the diff.

Actually, a git diff would be the best.

[maxGimeno]

Careful, now there are misisng include headers errors:

/home/travis/build/CGAL/cgal/Polytope_distance_d/include/CGAL/Width_polyhedron_3.h:166:5: error: 
      use of undeclared identifier 'endl'; did you mean 'std::endl'?
    DEBUGENDL(VISITED_CHECK,"Visited flag value of edge "

[maxGimeno]

This PR is not in shape to be tested.

[lrineau]

I have removed it from the 5.1 milestone (Trash/stalled).

[lrineau]

@sloriot

I would like to have the time to revive this branch, and then use Github Actions to automatically rebuild the graph at each pull-requests and pushes.