Trapezoid map fixes#4278
Closed
sloriot wants to merge 11 commits intoCGAL:releases/CGAL-4.14-branchfrom
Closed
Conversation
cw source must be v and cw is the first halfedge seen from noon when using cw order
direction is not a good criteria, especially for dangling edges
a halfedge can be associated to several nodes in the dag (since a halfedge can contribute to several trapezoids)
Contributor
Member
|
I actually think that the issue is from PR #4284. I have bisected the error and found a commit from it. See #4284 (comment). |
Contributor
|
Sorry I didn't see #4284 was in integration :/ |
Contributor
```
include/CGAL/Arr_point_location/Td_active_trapezoid.h:98:10: warning: class Non_recursive_td_map_item_destructor was previously declared as a struct [-Wmismatched-tags]
friend class internal::Non_recursive_td_map_item_destructor<Traits>;
^
```
Member
|
I fix the warning in 7143b69. |
sloriot
added
the
Not yet approved
Member
|
Why "Not yet approved"? I have already merged the PR in |
Member
Author
|
Michal will be doing a review next week and it seems that all the issues reported are not yet fixed. Not a big deal if 5.0 is not released before this PR is integrated in 4.14-branch. |
lrineau
added
the
Not yet approved
sloriot
removed
the
Not yet approved
Member
Author
|
After an online meeting, @MichalKleinbort and @efifogel approved the changes. |
Contributor
Member
Member
Author
|
@efifogel looks like the point location that is failing on some platforms is the landmark one. Are you familiar with this one? If yes, would you mind have a look? (This PR is one of the last blocking the release) |
Member
|
Sure, I'll look into it for starters. Stay tuned...
…On Wed, Nov 6, 2019, 16:51 Sebastien Loriot ***@***.***> wrote:
@efifogel <https://github.com/efifogel> looks like the point location
that is failing on some platforms is the landmark one. Are you familiar
with this one? If yes, would you mind have a look? (This PR is one of the
last blocking the release)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4278?email_source=notifications&email_token=ABVBNOCZHGSNI2AWHUR5PSLQSLKVPA5CNFSM4I6TJAC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDGZK4Y#issuecomment-550344051>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNOGAMP5I25Z6ZJ62OQLQSLKVPANCNFSM4I6TJACQ>
.
|
Member
|
Hi Sebastien,
I cannot seem to reproduce the problem.
I'm running Ubuntu 16.04.
I've installed gcc 7; see output of 'gcc-7 --version' below and used it.
gcc-7 (Ubuntu 7.4.0-1ubuntu1~16.04~ppa1) 7.4.0
but they all pass.
Any idea how I can try to reproduce?
Efi
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Thu, 7 Nov 2019 at 15:53, Efi Fogel ***@***.***> wrote:
Sure, I'll look into it for starters. Stay tuned...
On Wed, Nov 6, 2019, 16:51 Sebastien Loriot ***@***.***>
wrote:
> @efifogel <https://github.com/efifogel> looks like the point location
> that is failing on some platforms is the landmark one. Are you familiar
> with this one? If yes, would you mind have a look? (This PR is one of the
> last blocking the release)
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#4278?email_source=notifications&email_token=ABVBNOCZHGSNI2AWHUR5PSLQSLKVPA5CNFSM4I6TJAC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDGZK4Y#issuecomment-550344051>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABVBNOGAMP5I25Z6ZJ62OQLQSLKVPANCNFSM4I6TJACQ>
> .
>
|
Contributor
|
@sloriot What is the status of thi PR ? |
Member
Author
|
We don't know how to reproduce the error from the testsuite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The incremental update and rebuild function seemed to be broken. Also avoid recursive calls to
~Handle().