Skip to content

PMP: Self_intersections_with_tree#4344

Closed
maxGimeno wants to merge 9 commits intoCGAL:masterfrom
maxGimeno:AABB_tree_for_self_intersection-maxGimeno
Closed

PMP: Self_intersections_with_tree#4344
maxGimeno wants to merge 9 commits intoCGAL:masterfrom
maxGimeno:AABB_tree_for_self_intersection-maxGimeno

Conversation

@maxGimeno
Copy link
Copy Markdown
Contributor

Summary of Changes

Use a custom traaits for aabb_tree to compute self_intersections.

Bench here

Release Management

  • Affected package(s):PMP
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership:

@sloriot
Copy link
Copy Markdown
Member

sloriot commented Nov 7, 2019

The timing are not favorable to this implementation because Box_intersection_d test box vs box (meaning a lot of query triangles to be tested are eliminated at the same time) instead of face vs tree in the current implementation. I guess we have to use the tree/tree intersection.

@sloriot
Copy link
Copy Markdown
Member

sloriot commented Nov 7, 2019

For archive my timing with 289ce74 and this.

Input has 703512 faces.
Building the tree takes: 0.451887s.
New version in parallel takes: 15.6277s (0).
New version in sequential takes: 90.8133s (0).
Old version takes: 1.21053s (0).

@sloriot sloriot added Not yet approved The feature or pull-request has not yet been approved. Pkg::AABB_tree Pkg::PMP Under discussion labels Nov 7, 2019
@MaelRL MaelRL added this to the Trash / Attic milestone Oct 14, 2020
@sloriot sloriot closed this Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Not yet approved The feature or pull-request has not yet been approved. Pkg::AABB_tree Pkg::PMP Under discussion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants