Triangulation_2 : Document the Triangulation_2_projection_traits_3 class

[maxGimeno]

Summary of Changes

Add doc to the class T2_projection_traits_3.

TODO:

• add an example
• handle retro compatibility

Release Management

• Affected package(s):Triangulation_2
• Issue(s) solved (if any): fix Document Triangulation_2_projection_traits_3 #2915
• Small feature: https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/Triangulation_2_projection_traits_3 -- Pre-approved by User:Sloriot -- 2021/08/26
• link to the doc : https://cgal.github.io/5407/v6/Kernel_23/classCGAL_1_1Projection__traits__3.html

[maxGimeno]

/build:v1

[github-actions]

The documentation is built. It will be available, after a few minutes, here : https://cgal.github.io/5407/v1/Manual/index.html

[afabri]

@maxGimeno can you please make the changes and build the documentation again.

Also, unless I missed that a reviewer has spotted it as well, Project_to_plan is wrong. It should be Project_to_plane, but maybe even that is wrong as we have the concept ConstructProjectedPoint_3.

@sloriot @MaelRL any opinion on the name?

[maxGimeno]

/build:v2

[github-actions]

The documentation is built. It will be available, after a few minutes, here : https://cgal.github.io/5407/v2/Manual/index.html

[sloriot]

I don't think it needs to be documented.

[afabri]

I don't think it needs to be documented.

Just to be sure that I understand you right: There is no need to document it, as none of the 2D triangulation classes will ever call it, as there is no need for it to project points directly?

[sloriot]

it is not used and there is actually no plane since only a normal is requested.

[afabri]

/build:v3

[github-actions]

The documentation is built. It will be available, after a few minutes, here : https://cgal.github.io/5407/v3/Manual/index.html

[afabri]

I do not understand why it is in the triangulation package and not just in the Kernel as the other projection traits classes.

[sloriot]

Projection traits are models of PolygonTraits_2, ConvexHullTraits_2, TriangulationTraits_2, DelaunayTriangulationTraits_2, ConstrainedTriangulationTraits_2, ConvexHullTraits_2 and DelaunayMeshTraits_2. If this class is only model of triangulation concepts it makes sense to be here. If it is model of more then it can be moved in kernel, renamed + headers and template alias added for backward compatibility.

[sloriot]

Tests failing. For example here

[sloriot]

Example name conflicting with Weights/examples/Weights/projection_traits.cpp

[maxGimeno]

Successfully tested in https://cgal.geometryfactory.com/CGAL/testsuite/results-5.4-Ic-40.shtml