Skip to content

[Small Feature] Add bounded error Hausdorff distance#5475

Merged
lrineau merged 148 commits intoCGAL:masterfrom
sloriot:gsoc2019-PMPHDist-martinskrodzki
Jul 27, 2021
Merged

[Small Feature] Add bounded error Hausdorff distance#5475
lrineau merged 148 commits intoCGAL:masterfrom
sloriot:gsoc2019-PMPHDist-martinskrodzki

Conversation

@sloriot
Copy link
Member

@sloriot sloriot commented Feb 19, 2021 •
edited by danston
Loading

Summary of Changes

A new function added in PMP that computes the bounded-error Hausdorff distance between two meshes.

Release Management

This PR depends on #5544.

  • Affected package(s): PMP
  • Feature/Small Feature (if any): Small Feature
  • Link to compiled documentation (obligatory for small feature): docs
  • License and copyright ownership: GF

TODOs:

  • update changes
  • add small feature
  • check memory leaking
  • Must be merged after PMP: compare_meshes #5544 and checked that no rebased happened in the meantime

msmathcomp added 30 commits May 21, 2019 11:56
@msmathcomp
Initial version of bounded_error_hausdorff method.
82e8e4b
@msmathcomp
Implemented distance computation from mesh_1 vertices to mesh_2 trian…
04a05c0 
…gles.
@msmathcomp
Implement first rough approximation.
951e4a7
@msmathcomp
Fix initialization of global upper bound, include TODOs for further s…
9df0d3f 
…teps.
@msmathcomp
Add detailed comments on the code written so far and merge face proce…
c28f007 
…ssing loop into previous loop.
@msmathcomp
Add traversal trait for Hausdorff-based AABB traversal on the first t…
a67fa38 
…riangle mesh.
@msmathcomp
Add second traversal trait for Hausdorff-based AABB traversal on the …
04c84ef 
…second triangle mesh.
@msmathcomp
Fixed initialization of local Hausdorff bounds.
1400662
@msmathcomp
Pass tm2_tree instance to the traversal of tm1
d93aa73
@msmathcomp
Implement calling of TM2_tree traversal.
a4112c4
@msmathcomp
Finish traversal traits of tm1, i.e. finish implementation of Culling…
c76db1e 
…OnA.
@msmathcomp
Implement vertex (TM1) to triangle (TM2) distance in traversal proces…
453ec15 
…sing.
@msmathcomp
Finish implementation of Culling on B (i.e. TM2) traversal.
6221ebe
@msmathcomp
Store candidate triangles in a set to be processed later.
48e159b
@msmathcomp
Correct implementation of Culling on second mesh.
7ec6c4c
@msmathcomp
Implement a non-trivial toy example to test subdivision with. Intende…
2a52382 
…d solution is: Hausdorff distance will be attained at Point (0,0,1) and should be sqrt(3).
@msmathcomp
Implement subdivision of a triangle from the candidate set.
68e9776
@msmathcomp
Fix typo in vertex lookup.
17b0003
@msmathcomp
Finish first working prototype giving correct answer on the toy example.
3c73230
@msmathcomp
Results of Code Review with Sebastien.
d8b6e7d
@msmathcomp
Use Kernel method instead of computations by hand.
519d37d
@msmathcomp
Enable reading of real meshes and perturbation of them for distance c…
0332d9f 
…omputation.
@msmathcomp
Implement naive bounded Hausdoff computation by simple subdivision.
e78cbff
@msmathcomp
Comment naive comparison method.
000604f
@msmathcomp
Bugfix computation of upper bound, should not go below lower bound.
3134025
@msmathcomp
Add naive and optimized Hausdorff implementation to test file.
30b6c70
@msmathcomp
Introduce an additional stopping criterion to stop in degenerate case…
98e92a9 
…s where a triangle is never projected onto a single triangle in the other mesh.
@msmathcomp
Bugfix entering nodes of TM2 when traversing it.
130dcbc
@msmathcomp
Add timing to the example file and restore all tests in the test file.
c91c780
@msmathcomp
Implement benchmarking on both time and number of culled triangles.
156cac5
@sloriot sloriot force-pushed the gsoc2019-PMPHDist-martinskrodzki branch from 564fb28 to d8a375b Compare July 20, 2021 19:53
@sloriot
Copy link
Member Author

sloriot commented Jul 20, 2021

@danston Note that it filtered the branch to remove large files. You'll have to hard reset your local copy.

@maxGimeno
Copy link
Contributor

maxGimeno commented Jul 22, 2021

warning: https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-5.4-Ic-12/Polygon_mesh_processing/TestReport_Sosno_MSVC-2022-Preview-Release.gz

@maxGimeno
Copy link
Contributor

maxGimeno commented Jul 27, 2021

tested in https://cgal.geometryfactory.com/CGAL/testsuite/results-5.4-Ic-15.shtml

@lrineau lrineau added the TODO label Jul 27, 2021
@lrineau

This comment has been minimized.

Sign in to view
@danston

This comment has been minimized.

Sign in to view
@lrineau lrineau added rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' and removed TODO labels Jul 27, 2021
@lrineau

This comment has been minimized.

Sign in to view
@lrineau lrineau merged commit 4fb9075 into CGAL:master Jul 27, 2021
@lrineau lrineau removed Ready to be tested Under Testing rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' labels Jul 27, 2021
@lrineau lrineau deleted the gsoc2019-PMPHDist-martinskrodzki branch July 27, 2021 15:10
@sloriot sloriot added the gsoc label Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afabri afabri afabri left review comments

@lrineau lrineau lrineau left review comments

+2 more reviewers

@danston danston danston left review comments

@maxGimeno maxGimeno maxGimeno left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@danston danston

Labels

Accepted small feature gsoc gsoc-2019 Merged_in_5.4-beta1 Merged_in_5.4 Pkg::PMP Small feature Tested

Projects

None yet

Milestone

5.4-beta

Development

Successfully merging this pull request may close these issues.

7 participants

@sloriot @danston @maxGimeno @lrineau @afabri @msmathcomp @MaelRL