Skip to content

Number_types: Add Is_zero functor for Gmpq #5584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lrineau merged 4 commits into from
Jul 7, 2021
Merged

Number_types: Add Is_zero functor for Gmpq #5584

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
102eb01
Add Gmpq::is_zero()
afabri Apr 4, 2021
93fc1ae
Add Gmpq::is_zero()
afabri Apr 4, 2021
fc2863c
Simplify
afabri Apr 5, 2021
745eb86
Add Is_negative and Is_positive
afabri Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Number_types/include/CGAL/GMP/Gmpq_type.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,12 @@ class Gmpq
double to_double() const noexcept;
Sign sign() const noexcept;

bool is_zero() const
{
const __mpz_struct* zn = mpq_numref(mpq());
return mpn_zero_p(zn->_mp_d, zn->_mp_size);
Copy link
Member

@mglisse mglisse Apr 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the same code as mpq_class, i.e. mpq_sgn(mpq())==0, or mpz_size(mpq_numref(mpq()))==0? Or if you want to use internals, you only need to check if zn->_mp_size is 0.

}

const mpq_t & mpq() const noexcept { return Ptr()->mpQ; }
mpq_t & mpq() noexcept { return ptr()->mpQ; }

Expand Down
10 changes: 10 additions & 0 deletions Number_types/include/CGAL/Gmpq.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,16 @@ template <> class Algebraic_structure_traits< Gmpq >
typedef Tag_true Is_exact;
typedef Tag_false Is_numerical_sensitive;

class Is_zero
: public CGAL::cpp98::unary_function<Type&,
bool > {
public:
bool operator()( const Type& x_) const {
return x_.is_zero();
}
};


class Is_square
: public CGAL::cpp98::binary_function< Type, Type&,
bool > {
Expand Down