PMP Corefinement: Replace containers to make it faster#5592
Merged
sloriot merged 3 commits intoCGAL:masterfrom Aug 30, 2021
Merged
PMP Corefinement: Replace containers to make it faster#5592sloriot merged 3 commits intoCGAL:masterfrom
sloriot merged 3 commits intoCGAL:masterfrom
Conversation
sloriot
changed the title
sloriot
approved these changes
Apr 8, 2021
Member
|
Compilation error: https://github.com/CGAL/cgal/pull/5592/checks?check_run_id=2296005481#step:4:670 That seems a serious cons against the unordered_map: it seems part of the code uses the ordering. |
This makes the unordered_map change working for autoref
Member
|
Successfully tested in CGAL-5.4-Ic-38 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Running vtune for corefinement of meshes with coplanar faces showed that we can improve by replacing by a hash map.
Astonishingly it degraded performance when also doing it for another container here
Release Management