Merged
Conversation
mglisse
approved these changes
May 28, 2021
Member
mglisse
left a comment
There was a problem hiding this comment.
Note that I am not familiar at all with this package, I was probably just looking for the string "Lazy".
Maybe NT could be Exact_rational.
Member
Author
|
I just also cleaned up the benchmarks a little bit. When grepping for "lazy" I discovered the file |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
No longer mention
Lazy_circular_kernel_2in the test. We leave it in benchmark though.Release Management