Skip to content

Projection Traits With Centroid 2 and Determinant 2#5736

Merged
lrineau merged 6 commits intoCGAL:masterfrom
danston:Kernel_23-add_centroid_2_and_determinant_2-danston
Jul 27, 2021
Merged

Projection Traits With Centroid 2 and Determinant 2#5736
lrineau merged 6 commits intoCGAL:masterfrom
danston:Kernel_23-add_centroid_2_and_determinant_2-danston

Conversation

@danston
Copy link
Contributor

@danston danston commented May 28, 2021 •
edited
Loading

This little PR extends the Kernel 23 Projection Traits with two objects:

  • the one for computing 2D centroids
  • the one for computing 2D determinants

This PR is required by the new package called Weights (PR #5737) where the two objects above make the part of the Weight concept.

Tasks:

  • Check memory leaking.
  • Remove tmp modif in the docs.

Release Management

  • Affected package(s): Kernel_23
  • Issue(s) solved (if any): no issues
  • Feature/Small Feature (if any): Small Feature pre-approved on June 25, 2021
  • Link to compiled documentation (obligatory for small feature): docs
  • License and copyright ownership: no change

@danston danston mentioned this pull request Jun 11, 2021
Merged
@danston danston marked this pull request as ready for review June 11, 2021 15:00
@danston danston added Not yet approved The feature or pull-request has not yet been approved. Pkg::Kernel_23 labels Jun 11, 2021
@danston danston mentioned this pull request Jun 11, 2021
Merged
@afabri afabri added pre-approved For pre-approved small features. After 15 days the feature will be accepted. Ready to be tested and removed Not yet approved The feature or pull-request has not yet been approved. labels Jun 25, 2021
@danston danston requested a review from sloriot June 25, 2021 09:52
@danston
Copy link
Contributor Author

danston commented Jun 25, 2021

@sloriot Could you please make the review of this code change to be sure that I did not make any mistake? Thanks!

@MaelRL MaelRL added Accepted small feature Small feature and removed pre-approved For pre-approved small features. After 15 days the feature will be accepted. labels Jul 23, 2021
@MaelRL MaelRL added this to the 5.4-beta milestone Jul 23, 2021
@maxGimeno
Copy link
Contributor

maxGimeno commented Jul 27, 2021

tested in https://cgal.geometryfactory.com/CGAL/testsuite/results-5.4-Ic-15.shtml

@lrineau
Copy link
Member

lrineau commented Jul 27, 2021

Should this small feature add something in the CHANGES.md?

@lrineau lrineau self-assigned this Jul 27, 2021
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jul 27, 2021
@lrineau lrineau merged commit 04b690b into CGAL:master Jul 27, 2021
@lrineau lrineau removed rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' Ready to be tested Under Testing labels Jul 27, 2021
@danston danston deleted the Kernel_23-add_centroid_2_and_determinant_2-danston branch August 18, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sloriot sloriot sloriot approved these changes

Assignees

@lrineau lrineau

Labels

Accepted small feature Merged_in_5.4-beta1 Merged_in_5.4 Pkg::Kernel_23 Small feature Tested

Projects

None yet

Milestone

5.4-beta

Development

Successfully merging this pull request may close these issues.

6 participants

@danston @maxGimeno @lrineau @sloriot @afabri @MaelRL