Clang-tidy: google-readability-casting

[maxGimeno]

Summary of Changes

Apply google-readability-casting to the off plugin.

Release Management

• Affected package(s):
• Issue(s) solved (if any): fix clang-tidy google-readability-casting rule #5744

[lrineau]

The 3D demo, with all its OpenGL code, will be an heavy user of casts. Let's hope the patch will be smaller on CGAL headers.

[maxGimeno]

Appart from that, are you satisfied ? Should I run it on the whole demo ? A whole testsuite ?

[lrineau]

Appart from that, are you satisfied ? Should I run it on the whole demo ? A whole testsuite ?

Yes: it seems to do what is expected. Have it run a few packages, like Mesh_2 and Mesh_3, to see how it deals with templated code. Then, if those tests are good, we will go on and continue on the whole CGAL testsuite.

[sloriot]

@maxGimeno could you please refresh this branch so that it can be tested? We will keep the scope of this PR to the demo. If you have time this week, you can open another for the rest of CGAL.

[maxGimeno]

Successfully tested in https://cgal.geometryfactory.com/CGAL/testsuite/results-5.4-Ic-42.shtml

[lrineau]

Why do we remove modernize-use-nullptr?!

[sloriot]

a mistake I'd say. I'll restore it (or you can do it) directly in master once I'm done with checks on another PR.