Merged
Conversation
# Ceci est le premier message de validation : First step of action # Ceci est le message de validation numéro 2 : add ssh stuff # Ceci est le message de validation numéro 3 : Update github action # Ceci est le message de validation numéro 4 : Fix Logic # Ceci est le message de validation numéro 5 : Don't override the PATH !!! # Ceci est le message de validation numéro 6 : Download the known host too, so it is possible to add new IPs in it. # Ceci est le message de validation numéro 7 : Fix GIT path and better management of VERSION_NUMBER
add ssh stuff Update github action Fix Logic Don't override the PATH !!! Download the known host too, so it is possible to add new IPs in it. Fix GIT path and better management of VERSION_NUMBER fix autotest_cgal Fixes for scripts
Add test collection script odifications for "skipped" fixes on conditions
lrineau
reviewed
Jul 23, 2021
| result-encoding: string | ||
| script: | | ||
| const userName = context.payload.comment.user.login | ||
| if(userName == 'maxGimeno') { |
Member
There was a problem hiding this comment.
We'll have to adapt that logic! 😄
Member
|
lrineau
added
the
Not yet approved
maxGimeno
force-pushed
the
Testsuite-Filter_testsuite-maxGimeno
branch
from
0aaa2cc to
02152ab
Compare
lrineau
reviewed
Jul 30, 2021
lrineau
reviewed
Jul 30, 2021
Comment on lines
+24
to
+35
| - uses: actions/github-script@v3 | ||
| if: steps.check.result != 'stop' | ||
| id: get_label | ||
| with: | ||
| result-encoding: string | ||
| script: | | ||
| //get branch name and username | ||
| const pr_url = context.payload.issue.pull_request.url | ||
| const pr_content = await github.request(pr_url) | ||
| const label = pr_content.data.head.label | ||
| console.log(label) | ||
| return label |
Member
There was a problem hiding this comment.
This step cannot be skipped, because a comment even does not have access to the full PR payload, and we need to request it using github.request.
lrineau
reviewed
Jul 30, 2021
lrineau
reviewed
Jul 30, 2021
lrineau
reviewed
Jul 30, 2021
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/github-script@v3 | ||
| if: github.event.comment.user.login == 'maxGimeno' && contains(github.event.comment.body, '/testme') |
Member
There was a problem hiding this comment.
Here you use jobs.<job_id>.steps[*].if, and the conditional could be factorized to the job, using jobs.<job_id>.if, I think. I have not tested. I just read the doc.
lrineau
reviewed
Jul 30, 2021
lrineau
approved these changes
Jul 30, 2021
Member
|
I think we can merge this PR. The only files that could impact the CGAL testsuite are:
and none of them have been modified since the last time this PR was tested (see #5865 (comment)). |
lrineau
removed
the
Not yet approved
Member
|
I still see possible improvement, like the factorization of copy-pasted files in Do you agree @maxGimeno? |
Contributor
Author
|
Yes, let's merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adds files and change scripts to run the Filter testsuite from github.
Release Management