Use light mode in the doc by default

[sloriot]

No description provided.

[albert-github]

What is the intention here different from the setting HTML_COLORSTYLE=LIGHT? Wouldn't it be much better to set the doxygen setting HTML_COLORSTYLE to LIGHT ?

From the doxygen Documentation:

HTML_COLORSTYLE

The HTML_COLORSTYLE tag can be used to specify if the generated HTML output should
be rendered with a dark or light theme.
Possible values are: LIGHT always generate light mode output, DARK always generate dark mode output,
AUTO_LIGHT automatically set the mode according to the user preference, use light mode if no preference
is set (the default), AUTO_DARK automatically set the mode according to the user preference, use dark mode
if no preference is set and TOGGLE allow to user to switch between light and dark mode via a button.
The default value is: AUTO_LIGHT.

[sloriot]

I did not check but since we have custom headers this option will not be taken into account.

[albert-github]

The fact that CGAL uses custom headers is complicating things a bit, I still think that it will be a good idea to set:

HTML_COLORSTYLE        = LIGHT

as in that case some default files will be adjusted as well and might prevent some problems in the future.

I did a quick test with the Manual directory and e.g. in the file dynsections.js we see the differences:

127,128c127,128
<   plusImg:  [ "var(--fold-plus-image)",  "var(--fold-plus-image-relpath)" ],
<   minusImg: [ "var(--fold-minus-image)", "var(--fold-minus-image-relpath)" ],
---
>   plusImg:  [ "url('plus.svg')",  "url('../../plus.svg')" ],
>   minusImg: [ "url('minus.svg')", "url('../../minus.svg')" ],
156c156
<       'background':'linear-gradient(var(--fold-line-color),var(--fold-line-color)) no-repeat 46px/2px 100%'
---
>       'background':'linear-gradient(#808080,#808080) no-repeat 46px/2px 100%'

(lines < are without the setting HTML_COLORSTYLE = LIGHT).

Other files with differences are in .css file:

• doxygen.css
• navtree.css
• search/search.css
• tabs.css

Not performed changes here might lead to unexpected results in the layout / coloring when var(...) are not replaced.

[albert-github]

Besides the mentioned files I didn't find evidence that the light switch was used elsewhere.
I also searched for the word light and found no evidence that it would lead to problems.
So I think the setting HTML_COLORSTYLE = LIGHT can be used, unless you can point to a place where the setting leads to problems and the class="light-mode" doesn't.

[sloriot]

Successfully tested in CGAL-6.0-Ic-209

[lrineau]

See also what I have done in another PR: commit 6a45cc9.

The result is a cgal_stylesheet.css that seems compatible with light, dark, and print modes.

Screencast_20240701_165445.webm

[albert-github]

@lrineau
I don't know what you intended with your comment #8100 (comment)

1. I don't think the changes in the css should be hidden in PR New package: CGAL 3D conforming constrained Delaunay triangulations #8186 but should be in a PR of their own.
2. What setting did you use for the HTML_COLORSTYLE? or did you use the default setting AUTO_LIGHT?
3. Why setting just one color and not the way doxygen does it (see https://github.com/doxygen/doxygen/tree/master/templates/html directory and also https://github.com/doxygen/doxygen/blob/master/doc/doxygen_manual.cssfile
4. I see that you use the property background why not use background-color as background sets / influences not only background-color but also e.g. background-image etc