-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Generator: replace <boost/random.hpp> with <random> #8207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
afabri
wants to merge
10
commits into
CGAL:master
Choose a base branch
from
afabri:CGAL-binomial_distribution-GF
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloriot
reviewed
May 16, 2024
d5d24da
to
88b1877
Compare
Unless there is an important need, this PR will be for CGAL-6.1.x. |
Are there consequences in the CGAL documentation? |
@janetournois do you know why you use the |
Yes, And dealt with for example in |
Several full red lines in CGAL-6.0-Ic-285 because of this PR. |
@afabri did you check the red lines? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Replace
boost::
version withstd::
version.boost::
withstd::
forbinomial_distribution
,geometric_distribution
,uniform_real_distribution
boost::rand48
withstd::mt19937
boost::variate_generator
We still have from boost:
random_number_generator
,uniform_int
,uniform_small_int
,uniform_real
,uniform_01
,boost::lagged_fibonacci607
,Release Management