SMS: Make Lindstrom Turk placement more robust #8237
+327
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
We could even add it to the testsuite so that the error shows up. |
… small, define diff_of_product in a specific file
sloriot
reviewed
Feb 6, 2025
| @@ -219,6 +220,19 @@ std::optional< MatrixC33<R> > inverse_matrix(const MatrixC33<R>& m) | |||
|
|
|||
| if(! CGAL_NTS is_zero(det)) | |||
| { | |||
|
|
|||
| // RT c00 = diff_of_products(m.r1().y(),m.r2().z(),m.r2().y(),m.r1().z()) / det; | |||
There was a problem hiding this comment.
you wanted to uncomment that, right?
sloriot
reviewed
Feb 6, 2025
...clude/CGAL/Surface_mesh_simplification/Policies/Edge_collapse/internal/Lindstrom_Turk_core.h
Outdated
Show resolved
Hide resolved
sloriot
reviewed
Feb 6, 2025
...clude/CGAL/Surface_mesh_simplification/Policies/Edge_collapse/internal/Lindstrom_Turk_core.h
Outdated
Show resolved
Hide resolved
|
@MaelRL @LeoValque note that there are already functions called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Reduced data set to illustrate Issue #8213.
The collapse of edge
v1-v2results in a completely wrong placement of the vertex.The next step is to make the placement robust.
Release Management