Skip to content

New package: Frechet Distance #8284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 446 commits into from
Jun 5, 2025
Merged

New package: Frechet Distance #8284

merged 446 commits into from
Jun 5, 2025

Conversation

lrineau
Copy link
Member

@lrineau lrineau commented Jun 12, 2024

Summary of Changes

Add a new package computing the approximate Fréchet distance between two polylines in dD under Euclidean metric, or decides if the distance is smaller than a given value.

Release Management

  • Affected package(s): Frechet_distance
  • Feature (if any): link
  • License and copyright ownership: MPI, GeometryFactory, cnrs(?)

TODO:

  • check branch size (@sloriot)
  • Make it work with Epick_d<Dimension_tag<2>> @sloriot

@afabri afabri added this to the 6.1-beta milestone Jun 12, 2024
@afabri afabri linked an issue Jun 12, 2024 that may be closed by this pull request
@afabri

This comment was marked as outdated.

This comment was marked as outdated.

@afabri

This comment was marked as outdated.

This comment was marked as outdated.

@afabri

This comment was marked as outdated.

This comment was marked as outdated.

@afabri

This comment was marked as outdated.

This comment was marked as outdated.

@afabri

This comment was marked as outdated.

@MaelRL MaelRL added Not yet approved The feature or pull-request has not yet been approved. Feature CHANGES.md not updated labels Jun 18, 2024

This comment was marked as outdated.

@afabri

This comment was marked as outdated.

This comment was marked as outdated.

@afabri

This comment was marked as outdated.

This comment was marked as outdated.

@afabri

This comment was marked as outdated.

This comment was marked as duplicate.

@afabri

This comment was marked as outdated.

This comment was marked as outdated.

@afabri

This comment was marked as outdated.

This comment was marked as outdated.

@afabri

This comment was marked as outdated.

This comment was marked as outdated.

@afabri
Copy link
Member

afabri commented May 7, 2025

/force-build:v2

Copy link

github-actions bot commented May 7, 2025

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8284/v2/Manual/index.html

@afabri
Copy link
Member

afabri commented May 20, 2025

@sloriot compared the performance of the first commit at hash ad109d2
with Simple_cartesian<double> the latter with and without filtering.
With filtering the same performance as the initial version, and without filtering even faster than the initial version.
So with filtering is satisfying as it is certified, whereas without filtering we have no guarantee.
Epick and Epeck with filtering have the same performance. For Epeck_d it is not yet completely satisfying, but that should not be blocking.

@sloriot
Copy link
Member

sloriot commented Jun 4, 2025

Successfully tested in CGAL-6.1-Ic-167

This comment was marked as outdated.

@sloriot sloriot added Tested and removed Check size labels Jun 5, 2025
@sloriot sloriot merged commit 30b3388 into CGAL:master Jun 5, 2025
9 checks passed
@sloriot sloriot deleted the dev branch June 5, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Epick_d and Has_filtered_predicates_tag
7 participants