Skip to content

Shape_detection: Add a way to pass input normal to faces #8638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Shape_detection: Add a way to pass input normal to faces #8638

wants to merge 15 commits into from

Conversation

sloriot
Copy link
Member

@sloriot sloriot commented Dec 2, 2024 •
edited by MaelRL
Loading

Summary of Changes

Avoid computing them when they are known.

  • Normals are only used for estimating the angle between neighbor faces. PCA is used to estimate the plane.
  • sorting should be reusing the triangulation of faces that is already done in regions (pass the internal map to sort() for exemple). PCA is also used here to estimate the flatness score of a face in its neighborhood
  • About sorting: I'm not sure it wouldn't be a better idea to simply sort using the area of the faces and ignore flatness of the neighborhood.

Release Management

@sloriot sloriot requested a review from soesau January 6, 2025 14:16
soesau
soesau previously requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@soesau soesau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ! in Plane_face_region.h#320 looks like bug and at least the doc needs to be updated.

@sloriot
Copy link
Member Author

sloriot commented Jan 9, 2025

Successfully tested in CGAL-6.1-Ic-59

@sloriot sloriot added Not yet approved The feature or pull-request has not yet been approved. Previously tested and removed Under Testing labels Jan 9, 2025
@MaelRL MaelRL added this to the 6.1-beta milestone Feb 20, 2025
@MaelRL MaelRL modified the milestones: 6.1-beta, 6.2-beta Mar 17, 2025
@soesau soesau dismissed their stale review March 27, 2025 11:52

outdated

@soesau

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@soesau

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2025

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8638/v0/Manual/index.html

@sloriot
Copy link
Member Author

sloriot commented Apr 16, 2025

Successfully tested in CGAL-6.1-Ic-132

@sloriot sloriot marked this pull request as ready for review April 23, 2025 12:02
@lrineau lrineau changed the title Add a way to pass input normal to faces Shape_detection: Add a way to pass input normal to faces Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afabri afabri afabri left review comments

@soesau soesau soesau left review comments

Assignees
No one assigned
Labels
Enhancement Not yet approved The feature or pull-request has not yet been approved. Pkg::Shape_detection Small feature Tested
Projects
None yet
Milestone
6.2-beta
Development

Successfully merging this pull request may close these issues.
5 participants
@sloriot @soesau @afabri @MaelRL @janetournois