Skip to content

Remove bad offset initialization #8848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sloriot merged 1 commit into from
Apr 23, 2025
Merged

Remove bad offset initialization #8848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Periodic_3_mesh_3/include/CGAL/Periodic_3_mesh_triangulation_3.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,7 +964,6 @@ class Periodic_3_regular_triangulation_3_wrapper

// get the offset of the first weighted circumcenter
Offset transl_wc1;
transl_wc1.x() += 1;
for(;;) /* while not in */
{
// can safely perform a construction here because the kernel has exact constructions
Expand All @@ -991,6 +990,7 @@ class Periodic_3_regular_triangulation_3_wrapper
for(;;) /* while not in */
{
dp = etraits.construct_point_3_object()(exact_wc2, transl_wc2);

if(compute_x(dp) < dom.xmin())
transl_wc2.x() += 1;
else if(compute_y(dp) < dom.ymin())
Expand Down