SMDS_3 - add c3t3.set_triangulation()
#8851
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janetournois
changed the title
|
Successfully tested in CGAL-6.1-Ic-136 |
|
@janetournois Mergeable? |
|
The function is not documented, so I would say no. |
|
This pull-request was previously marked with the label |
janetournois
force-pushed
the
SMDS_3-fix_example-jtournois
branch
from
2c36c5f to
d4a335f
Compare
that internally calls rescan_after_load_of_triangulation() it avoids calling it explicitly or documenting it, but fixes the issue of updating the internal metadata of C3t3 automatically
janetournois
force-pushed
the
SMDS_3-fix_example-jtournois
branch
from
d4a335f to
9c58f6c
Compare
janetournois
changed the title
c3t3.set_triangulation()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading a .mesh file to a
Triangulation_3, and then aC3t3, as done in this example leads to aC3t3for whichnumber_of_facets()andnumber_of_cells()return 0, because the internal counters have not been updated byc3t3.triangulation() = tr.It is not clear to the user why these numbers are 0, and the function
rescan_after_load_of_triangulation()(which fixes the counters) is not documented.Summary of Changes
Add the use ofrescan_after_load_of_triangulation()in an example.The other option would be to use it automatically in the functions that load a triangulation.@lrineau @MaelRL do you have an opinion?Todo : discuss the APIAdd and document a function
c3t3.set_triangulation(const Tr& tr)that internally callsrescan_after_load_of_triangulation(), and is easier to useRelease Management