Skip to content

feat: read support for vn and vt added for OBJ file format #8857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mehull-26
Copy link
Contributor

Summary of Changes

This PR adds the ability to parse normals and texture coordinates from .obj files using the existing face parsing logic. This is currently internal-only, and not exposed in the documented API or parameter sets.

The goal is to fully integrate OBJ normal and texture support in a future PR, once the writer logic is updated, and a broader set of test cases are validated.

  • Internal parsing logic implemented
  • test added for face parsing with v/vt/vn syntax
  • Not exposed to public interface yet

Why not public yet?

  • Writer does not yet support output of texture and normal attributes.

Once these conditions are met, the feature will be promoted to the public API.

Release Management

  • Affected package(s): Stream Support
  • Issue(s) solved (if any): partially worked on #8344
  • Feature/Small Feature (if any): added capability of reading normals and texture coordinates in OBJ file format (not yet exposed to public API though, only kept to internal::read_obj() )
  • Link to compiled documentation (obligatory for small feature) Not yet exposed to the public API to write documentation for
  • License and copyright ownership: Same as CGAL

@mehull-26
Copy link
Contributor Author

Hey @sloriot, just wanted to check if you could take a look at this PR when you get a moment. It’s been idle for a day and I’d love your feedback. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant