AABB: Fixing 2D closest point for circles #8891
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plementation in Do_intersect_3
…inclusion as intersection
Filtered_kernel/include/CGAL/Filtered_kernel/internal/Static_filters/Do_intersect_2.h
Outdated
Show resolved
Hide resolved
as the intersection with inclusion function has been included into AABB_traits_2.h
MaelRL
added
the
Not yet approved
sloriot
reviewed
May 19, 2025
There was a problem hiding this comment.
Note that the added function is not filtered, that is plain floating point computation is used for the evaluation. It is not "worse" that constructing the radius of the circle I guess. A proper fix would also be needed in 3D for the radius too. So maybe it's fine for 6.1 but we should consider opening an issue to track and fix this once for all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
AABB_tree::closest_point()for circles may provide wrong points if a certain hints are provided.See https://gist.github.com/MaelRL/3d33fa83f0eea80c94da0966bb425f3a
do_intersect_circle_iso_rectangle_2()considers inclusion not as in intersectionRelease Management