Homological Discrete Vector Fields #9004
Open
+27,421
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to comply with the HDVF concept, splitted HDVF into -> HDVF_core (which will be inherited by all HDVF models) -> HDVF (which inherits HDVF_core and is the end user class for HDVF computing homology)
- Changed classes names from HDVF to Hdvf - Uniformized classes names: Hdvf_duality and Hdvf_persistence - namespace: HDVF
- finished the HDVF concept description - Hdvf_core rework ongoing
-> finished Hdvf_core -> starting Hdvf
-> Hdvf_persistence OK -> Filtration rework ongoing
Sub_chain_complex_mask documentation OK.
-> Concept SparseMatrix OK -> Starting Sparse_matrix rework
Documentation of Sparse_matrix ongoing
-> Finished Sparse_chain documentation
-> finished documenting both classes -> improved coherence by changing ALL Sparse_matrix getters to friend
-> finish documentation and rework of Sub_sparse_matrix class
-> documentation and rework of the class done !!!!! Why is it necessary to set get_flag as virtual in Hdvf_core ? While I don't see any dynamic types...
-> finished description and figure
-> all principal classes have been reworked TODO -> IO classes (tools_io) are still "as such" -> Tools for simplicial and cubical complexes are also "as such" (vtk exports, methods for duality) -> Unit tests -> Simplicial complexes duality still uses tetgen to mesh a sphere containing the triangle mesh. Should be coded with CGAL...
-> changing cohomology export (with or without cofaces)
-> updated Hdvf manual -> commented unnecessary parts in Hdvf
-> Hdvf_persistence OK (documentation / class)
-> modification de int à size_t pour le type des indices de cellules
-> corrected indices int -> size_t in HDVF_persistence, HDVF_duality, complexes tools, Simplicial complexes, Simplex, MeshIO -> corrected error on cohomology cofaces for duality (cofaces must be restricted to the sub chain complex) -> reworked illustrations of HDVF_duality
-> corrected indices type from int to size_t in Cubical_chain_complex and corresponding tools_io and tools
-> replaced int by size_t
-> Tested Hdvf, Hdvf_persistence, Hdvf_duality on simplicial and cubical chain complexes -> Preliminary documentation OK
-> unified vtk output for simplicial and cubical complexes -> replaced corresponding functions by templated vtk exporter (for Hdvf, Hdvf_persistence and Hdvf_duality) -> created classes to handle mesh duality operations for simplicial and cubical complexes (creation of the larger complex L homeomorphic to a ball and coding of the complex through a mask)
-> Even if user documentation is still "empty", added references to the articles introducing HDVFs and cited Aldo Gonzalez-Lorenzo (who introduced them in his PhD)
-> user documentation ongoing -> commit before correction of a bug in find_M family of functions
Exceptions OK + documentation
Revised all exceptions in Cub_object_io (+documentation)
Member
|
/force-build:v1 |
|
There was an error while building the doc: |
Member
|
/force-build:v1 |
|
There was an error while building the doc: |
Member
|
/force-build:v1 |
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9004/v1/Manual/index.html |
Member
|
/force-build:v1 |
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9004/v1/Manual/index.html |
… into Homology-new_package-AB
For all HDVF operations (A, R, M, W, MW) added a correponding operation to check the validity of a pair of argument cells provided by the user.
Added z and co_z functions to the API (functions defining fundamental cycles/co-cycle) Necessary to related HDVFs to tri-partitions
Added protected methods computing hd(sigma), <hd(sigtma), tau> and same for h^*d^*. These matrices are not store (for efficiency) so we must provide efficient computations for "advanced users" developping topological algorithms -> therefore the methods are protected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The pull request contains the first version of:
Release Management
HDVF/Surface_mesh_topology