remove 'using namespace std' from headers #9255
Merged
+116
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace 'using namespace std' with explicit std:: prefixes in validation functions and I/O operators to avoid namespace pollution. Affected files: - Bounding_volumes/include/CGAL/Min_circle_2.h - Bounding_volumes/include/CGAL/Min_circle_2/Min_circle_2_impl.h - Bounding_volumes/include/CGAL/Min_ellipse_2.h - Bounding_volumes/include/CGAL/Min_ellipse_2/Min_ellipse_2_impl.h - Bounding_volumes/include/CGAL/Min_annulus_d.h - Polytope_distance_d/include/CGAL/Polytope_distance_d.h
Member
|
This does not pollute anything, because the |
Contributor
Author
You are correct; since it is local, it doesn't pollute the global namespace. My goal was simply to align these files with modern C++ style and ensure consistency. If you view this as unnecessary code churn, let me know and I will close the PR |
lrineau
approved these changes
Jan 12, 2026
Member
lrineau
left a comment
lrineau
left a comment
There was a problem hiding this comment.
I agree that those changes are not strictly necessary. But would align those headers with the other usages in CGAL.
Member
|
Successfully tested in CGAL-6.2-Ic-82 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR removes
using namespace std;from files. It replaces implicit standard library calls with explicitstd::prefixes (e.g.,std::copy,std::endl,std::ostream_iterator,std::flush).Release Management
Bounding_volumes,Polytope_distance_d