Skip to content

Polygon mesh snapping improvements #9266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MaelRL wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Polygon mesh snapping improvements #9266

MaelRL wants to merge 10 commits into from

Conversation

@MaelRL
Copy link
Member

@MaelRL MaelRL commented Jan 12, 2026 •
edited
Loading

Summary of Changes

A few improvements for the experimental polygon mesh snapping functions of PMP.

TODO:

  • Add new regression tests

Release Management

  • Affected package(s): PMP
  • Feature/Small Feature (if any): n/a
  • License and copyright ownership: no change

MaelRL added 6 commits January 12, 2026 12:45
@MaelRL
Use decltype(auto) rather than Point_ref
159dbf4
@MaelRL
Misc debug improvements
60418fd
@MaelRL
Use a property map for the base tolerance values
d9e452d 
The point is that we can then either pass a tolerance map,
or a constant fixed value.
@MaelRL
In self-snapping, update the splitting position before splitting
fe531d2 
This is because if meshes are different, the target edge is fixed.
But if we are self-snapping, the edge might move because one of
its extremity might itself have been a vertex involved in vertex-edge
snapping.
@MaelRL
Reject vertex-edge snapping moves that invert normals
f35113c
@MaelRL
Update tolerance maps after intermediate operations
2afd629 
otherwise the tolerance (esp. the automatic one using 0.9 * min_inc_edge_l)
can grow too large and allow snapping to a neighbor-of-neighbor edge,
which obviously we need to avoid.
@MaelRL MaelRL added this to the 6.2-beta milestone Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@albert-github albert-github albert-github left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Enhancement Pkg::PMP Ready to be tested

Projects

None yet

Milestone

6.2-beta

Development

Successfully merging this pull request may close these issues.

3 participants

@MaelRL @albert-github @sloriot