Mesh 3 speedup balls wip jtournois #9274
Draft
+1,192
−530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and use it in domain.curve_segment_is_covered()
add a special locate_corner() because we don't want to store all incident polylines to a corner, and that it's only a few, cheap, locate operations
mesh_polyhedral_domain_with_features works fine with this version
the iterator we need is the one of p, not the one of `other_point`! + constify what can be + make loops more readable
and deal with the case where distance < 0 in point_at(), because we don't want to start from start_point all over
and add tons of assertions
…anetournois/cgal into Mesh_3-speedup_balls-jtournois # Conflicts: # Mesh_3/include/CGAL/Sizing_field_with_aabb_tree.h
…t_edges_sizing_field
it should be equal to begin iff p is begin otherwise, locate returns the previous segment source
this avoids confusion when the same point may belong to 2 features It may be the case when polyline input features are (almost) identical
afabri
reviewed
Jan 13, 2026
do not modify the C3T3
and a vertex on a feature may have only one adjacent vertex on the feature. In this case, we give up checking anything about the feature
enlarge the research region to a small sphere, to find the correct feature again
…om/janetournois/cgal into Mesh_3-speedup_balls_wip-jtournois
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please use the following template to help us managing pull requests.
Summary of Changes
Describe what your pull request changes to CGAL (this can be skipped if it solves an issue already in the tracker or if it is a Feature or Small Feature submitted to the CGAL Wiki).
Release Management