Skip to content

Conversation

@afabri
Copy link
Member

@afabri afabri commented Jan 14, 2026

Summary of Changes

Prefix macros. Some are include guards, some have relatively generic names.
Remove several files from CGAL_ImageIO and put the code in the files kept in namespace CGAL

Release Management

  • Affected package(s): several
  • License and copyright ownership: unchanged

@afabri afabri self-assigned this Jan 14, 2026
@afabri afabri added this to the 6.2-beta milestone Jan 14, 2026
@afabri
Copy link
Member Author

afabri commented Jan 14, 2026

@sloriot I am wondering if we include files from ImageIO like gif_impl.h as soon as we #include <CGAL/Image_3.h>. There is then no namespace, there are #define FALSE 0 etc.

@lrineau
Copy link
Member

lrineau commented Jan 15, 2026

@sloriot I am wondering if we include files from ImageIO like gif_impl.h as soon as we #include <CGAL/Image_3.h>. There is then no namespace, there are #define FALSE 0 etc.

Yes you are right. Those macro names should be fixed, or removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants