Skip to content

Conversation

@afabri
Copy link
Member

@afabri afabri commented Jan 16, 2026

Summary of Changes

Template parameters must be in CamelCase
Fix template parameters in the package description

Todo

  • Add the Insight Tool Kit, referedto here, to the 3rd party software page
  • Fix some todos in the code
  • Remove the first two template parameters and rewrite the documentation of the third one here.

Release Management

  • Affected package(s): Mesh_3
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership: unchanged

/// \name Types imported from the geometric traits class
///@{
/// The point type of the geometric traits class
/// @todo this should be BGT where we have to add Iso_cuboid in the concept
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we not document that the types come from BGT @janetournois ?

/*! \brief Construction from a function, a bounding object and a relative error bound.
*
* \tparam Function a type compatible with `Labeling_function`
* \tparam Function a type compatible with `Labeling_function` @todo fix this as this is no longer a template parameter
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The labeling functions is no longer a template parameter @janetournois

@afabri afabri requested a review from janetournois January 16, 2026 12:08
@afabri
Copy link
Member Author

afabri commented Jan 16, 2026

When did we deprecate this? Maybe we can remove it in this PR.

@afabri
Copy link
Member Author

afabri commented Jan 16, 2026

When did we deprecate this? Maybe we can remove it in this PR.

Deprecated 8 years ago in this commit

@afabri
Copy link
Member Author

afabri commented Jan 16, 2026

Is it correct that here we refer to the Surface_mesher package @janetournois

@janetournois
Copy link
Member

Is it correct that here we refer to the Surface_mesher package @janetournois

I don't think so. What part of the page do you refer to?

@afabri
Copy link
Member Author

afabri commented Jan 16, 2026

Is it correct that here we refer to the Surface_mesher package @janetournois

I don't think so. What part of the page do you refer to?

I refer to the sentence "This parameter stands for a model of the concept ImplicitFunction described in the surface mesh generation package"

@janetournois
Copy link
Member

Is it correct that here we refer to the Surface_mesher package @janetournois

I don't think so. What part of the page do you refer to?

I refer to the sentence "This parameter stands for a model of the concept ImplicitFunction described in the surface mesh generation package"

then yes, it is about Surface_mesher. Maybe it should be moved/copied to Mesh_3 now, since the Surface_mesher package got deprecated

@afabri

This comment was marked as outdated.

@github-actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9283/v0/Manual/index.html

\suitesparse is a set of sparse-matrix-related packages written or co-authored by Tim Davis, available at <A HREF="https://github.com/DrTimothyAldenDavis/SuiteSparse">https://github.com/DrTimothyAldenDavis/SuiteSparse</A>.

\suitesparse is used by the Orbifold Tutte Embedding and ARAP parametrization, i.e., in the surface parametrization package.
\suitesparse is used by the Orbifold Tutte Embedding and ARAP parametrization, i.e., in the \ref PkgSurfaceMeshParametrization package.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
\suitesparse is used by the Orbifold Tutte Embedding and ARAP parametrization, i.e., in the \ref PkgSurfaceMeshParametrization package.
\suitesparse is used by the Orbifold Tutte Embedding and ARAP parameterization, i.e., in the \ref PkgSurfaceMeshParameterization package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants