Fix incorrect parameter documentation in envelope merge helper #9284
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afabri
approved these changes
Jan 16, 2026
Member
afabri
left a comment
afabri
left a comment
There was a problem hiding this comment.
Thank you @ritiktpatel
@sloriot we can just merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes a documentation typo in
Envelope_divide_and_conquer_2.h.The parameter description for
_merge_envelopesincorrectly duplicated thedocumentation of
d1ford2. The comment is updated so thatd2is correctlydescribed as the second diagram representing the envelope of curve set
C2.No functional or behavioral changes are introduced.
Release Management