Skip to content

Fix #9369: Inline Doxygen documentation for tags.hMerge tags.h documentation into source file#9382

Open
sainathmanda7 wants to merge 3 commits intoCGAL:mainfrom
sainathmanda7:main
Open

Fix #9369: Inline Doxygen documentation for tags.hMerge tags.h documentation into source file#9382
sainathmanda7 wants to merge 3 commits intoCGAL:mainfrom
sainathmanda7:main

Conversation

@sainathmanda7
Copy link

Description
This PR resolves issue #9369 by moving the Doxygen documentation for <CGAL/tags.h> directly into the source code to act as the single source of truth.

Changes made:

  • Transferred all Doxygen comment blocks (///) from the detached documentation file directly into STL_Extension/include/CGAL/tags.h, placing them immediately above their respective struct and typedef declarations.
  • Deleted the now-redundant STL_Extension/doc/STL_Extension/CGAL/tags.h file to prevent duplicate documentation warnings and clean up the file tree.

Fixes #9369

Moves the Doxygen comments from the detached doc file directly into the header file. Fixes CGAL#9369
struct Parallel_tag : public Sequential_tag { static constexpr bool is_parallel = true; };

#ifdef CGAL_LINKED_WITH_TBB
/// \ingroup PkgSTLExtensionUtilities
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes no sense to have documentation to depend on a macro

@afabri
Copy link
Member

afabri commented Mar 18, 2026

/build:v0

@github-actions
Copy link

There was an error while building the doc:

/home/runner/work/cgal/cgal/Algebraic_foundations/doc/Algebraic_foundations/Concepts/RealEmbeddableTraits.h:30: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
/home/runner/work/cgal/cgal/Algebraic_foundations/doc/Algebraic_foundations/Concepts/RealEmbeddableTraits.h:30: warning: unable to resolve link to 'CGAL::Tag_false' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_2/doc/Alpha_shapes_2/CGAL/Alpha_shape_2.h:28: warning: unable to resolve link to 'Tag_true' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_2/doc/Alpha_shapes_2/CGAL/Alpha_shape_2.h:30: warning: unable to resolve link to 'Tag_false' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_2/doc/Alpha_shapes_2/CGAL/Alpha_shape_2.h:32: warning: unable to resolve link to 'Tag_false' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_2/doc/Alpha_shapes_2/CGAL/Alpha_shape_2.h:38: warning: unable to resolve link to 'Tag_true' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_2/doc/Alpha_shapes_2/CGAL/Alpha_shape_2.h:51: warning: unable to resolve link to 'Tag_true' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_2/doc/Alpha_shapes_2/CGAL/Alpha_shape_face_base_2.h:16: warning: unable to resolve link to 'Tag_true' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_2/doc/Alpha_shapes_2/CGAL/Alpha_shape_face_base_2.h:17: warning: unable to resolve link to 'Tag_false' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_2/doc/Alpha_shapes_2/CGAL/Alpha_shape_vertex_base_2.h:17: warning: unable to resolve link to 'Tag_true' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_2/doc/Alpha_shapes_2/CGAL/Alpha_shape_vertex_base_2.h:18: warning: unable to resolve link to 'Tag_false' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_3/doc/Alpha_shapes_3/CGAL/Alpha_shape_3.h:27: warning: unable to resolve link to 'Tag_true' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_3/doc/Alpha_shapes_3/CGAL/Alpha_shape_3.h:29: warning: unable to resolve link to 'Tag_false' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_3/doc/Alpha_shapes_3/CGAL/Alpha_shape_3.h:31: warning: unable to resolve link to 'Tag_false' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_3/doc/Alpha_shapes_3/CGAL/Alpha_shape_3.h:37: warning: unable to resolve link to 'Tag_true' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_3/doc/Alpha_shapes_3/CGAL/Alpha_shape_3.h:48: warning: unable to resolve link to 'Tag_true' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_3/doc/Alpha_shapes_3/CGAL/Alpha_shape_cell_base_3.h:16: warning: unable to resolve link to 'Tag_true' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_3/doc/Alpha_shapes_3/CGAL/Alpha_shape_cell_base_3.h:17: warning: unable to resolve link to 'Tag_false' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_3/doc/Alpha_shapes_3/CGAL/Alpha_shape_cell_base_3.h:18: warning: unable to resolve link to 'Tag_true' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_3/doc/Alpha_shapes_3/CGAL/Alpha_shape_cell_base_3.h:19: warning: unable to resolve link to 'Tag_true' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_3/doc/Alpha_shapes_3/CGAL/Alpha_shape_cell_base_3.h:20: warning: unable to resolve link to 'Tag_false' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_3/doc/Alpha_shapes_3/CGAL/Alpha_shape_cell_base_3.h:20: warning: unable to resolve link to 'Tag_false' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_3/doc/Alpha_shapes_3/CGAL/Alpha_shape_vertex_base_3.h:16: warning: unable to resolve link to 'Tag_true' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_3/doc/Alpha_shapes_3/CGAL/Alpha_shape_vertex_base_3.h:17: warning: unable to resolve link to 'Tag_false' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_3/doc/Alpha_shapes_3/CGAL/Alpha_shape_vertex_base_3.h:18: warning: unable to resolve link to 'Tag_true' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_3/doc/Alpha_shapes_3/CGAL/Alpha_shape_vertex_base_3.h:19: warning: unable to resolve link to 'Tag_true' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_3/doc/Alpha_shapes_3/CGAL/Alpha_shape_vertex_base_3.h:20: warning: unable to resolve link to 'Tag_false' for \link command
/home/runner/work/cgal/cgal/Alpha_shapes_3/doc/Alpha_shapes_3/CGAL/Alpha_shape_vertex_base_3.h:20: warning: unable to resolve link to 'Tag_false' for \link command
/home/runner/work/cgal/cgal/BGL/doc/BGL/CGAL/boost/graph/properties.h:53: warning: unable to resolve link to 'Tag_true' for \link command
/home/runner/work/cgal/cgal/BGL/doc/BGL/CGAL/boost/graph/properties.h:55: warning: unable to resolve link to 'Tag_false' for \link command
/home/runner/work/cgal/cgal/Combinatorial_map/doc/Combinatorial_map/Concepts/CellAttribute.h:84: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
/home/runner/work/cgal/cgal/Combinatorial_map/doc/Combinatorial_map/Concepts/CellAttribute.h:74: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
/home/runner/work/cgal/cgal/Combinatorial_map/doc/Combinatorial_map/Concepts/CellAttribute.h:79: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
/home/runner/work/cgal/cgal/Combinatorial_map/doc/Combinatorial_map/Concepts/CellAttribute.h:39: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
/home/runner/work/cgal/cgal/Combinatorial_map/doc/Combinatorial_map/Concepts/CellAttribute.h:39: warning: unable to resolve link to 'CGAL::Tag_false' for \link command
/home/runner/work/cgal/cgal/Combinatorial_map/doc/Combinatorial_map/Concepts/CellAttribute.h:39: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
/home/runner/work/cgal/cgal/Combinatorial_map/doc/Combinatorial_map/Concepts/CellAttribute.h:39: warning: unable to resolve link to 'CGAL::Tag_false' for \link command
/home/runner/work/cgal/cgal/Combinatorial_map/doc/Combinatorial_map/Concepts/CellAttribute.h:74: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
/home/runner/work/cgal/cgal/Combinatorial_map/doc/Combinatorial_map/Concepts/CellAttribute.h:79: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
/home/runner/work/cgal/cgal/Combinatorial_map/doc/Combinatorial_map/Concepts/CellAttribute.h:84: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
/home/runner/work/cgal/cgal/Combinatorial_map/doc/Combinatorial_map/Concepts/CellAttribute.h:84: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
/home/runner/work/cgal/cgal/Combinatorial_map/doc/Combinatorial_map/Concepts/GenericMap.h:432: warning: unable to resolve link to 'CGAL::Tag_false' for \link command
/home/runner/work/cgal/cgal/Combinatorial_map/doc/Combinatorial_map/Concepts/GenericMap.h:424: warning: unable to resolve link to 'CGAL::Tag_false' for \link command
/home/runner/work/cgal/cgal/Combinatorial_map/doc/Combinatorial_map/CGAL/Cell_attribute.h:15: warning: explicit link request to 'Tag_true' could not be resolved
/home/runner/work/cgal/cgal/Combinatorial_map/doc/Combinatorial_map/CGAL/Cell_attribute.h:15: warning: explicit link request to 'Tag_false' could not be resolved
/home/runner/work/cgal/cgal/Combinatorial_map/doc/Combinatorial_map/CGAL/Cell_attribute.h:15: warning: explicit link request to 'Tag_true' could not be resolved
/home/runner/work/cgal/cgal/Combinatorial_map/doc/Combinatorial_map/CGAL/Cell_attribute_with_id.h:15: warning: explicit link request to 'Tag_true' could not be resolved
/home/runner/work/cgal/cgal/Combinatorial_map/doc/Combinatorial_map/CGAL/Cell_attribute_with_id.h:15: warning: explicit link request to 'Tag_false' could not be resolved
/home/runner/work/cgal/cgal/Combinatorial_map/doc/Combinatorial_map/CGAL/Cell_attribute_with_id.h:15: warning: explicit link request to 'Tag_true' could not be resolved
/home/runner/work/cgal/cgal/Combinatorial_map/doc/Combinatorial_map/Combinatorial_map.txt:199: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
/home/runner/work/cgal/cgal/Generalized_map/doc/Generalized_map/Generalized_map.txt:198: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
/home/runner/work/cgal/cgal/HalfedgeDS/doc/HalfedgeDS/Concepts/HalfedgeDSHalfedge.h:120: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
/home/runner/work/cgal/cgal/HalfedgeDS/doc/HalfedgeDS/Concepts/HalfedgeDSHalfedge.h:120: warning: unable to resolve link to 'CGAL::Tag_false' for \link command
/home/runner/work/cgal/cgal/HalfedgeDS/doc/HalfedgeDS/Concepts/HalfedgeDSHalfedge.h:110: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
/home/runner/work/cgal/cgal/HalfedgeDS/doc/HalfedgeDS/Concepts/HalfedgeDSHalfedge.h:110: warning: unable to resolve link to 'CGAL::Tag_false' for \link command
/home/runner/work/cgal/cgal/HalfedgeDS/doc/HalfedgeDS/Concepts/HalfedgeDSHalfedge.h:115: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
/home/runner/work/cgal/cgal/HalfedgeDS/doc/HalfedgeDS/Concepts/HalfedgeDSHalfedge.h:115: warning: unable to resolve link to 'CGAL::Tag_false' for \link command
/home/runner/work/cgal/cgal/HalfedgeDS/doc/HalfedgeDS/Concepts/HalfedgeDSHalfedge.h:110: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
/home/runner/work/cgal/cgal/HalfedgeDS/doc/HalfedgeDS/Concepts/HalfedgeDSHalfedge.h:110: warning: unable to resolve link to 'CGAL::Tag_false' for \link command
/home/runner/work/cgal/cgal/HalfedgeDS/doc/HalfedgeDS/Concepts/HalfedgeDSHalfedge.h:115: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
/home/runner/work/cgal/cgal/HalfedgeDS/doc/HalfedgeDS/Concepts/HalfedgeDSHalfedge.h:115: warning: unable to resolve link to 'CGAL::Tag_false' for \link command
/home/runner/work/cgal/cgal/HalfedgeDS/doc/HalfedgeDS/Concepts/HalfedgeDSHalfedge.h:120: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
/home/runner/work/cgal/cgal/HalfedgeDS/doc/HalfedgeDS/Concepts/HalfedgeDSHalfedge.h:120: warning: unable to resolve link to 'CGAL::Tag_false' for \link command
/home/runner/work/cgal/cgal/Linear_cell_complex/doc/Linear_cell_complex/CGAL/Cell_attribute_with_point.h:13: warning: explicit link request to 'Tag_true' could not be resolved
/home/runner/work/cgal/cgal/Linear_cell_complex/doc/Linear_cell_complex/CGAL/Cell_attribute_with_point.h:13: warning: explicit link request to 'Tag_false' could not be resolved
/home/runner/work/cgal/cgal/Linear_cell_complex/doc/Linear_cell_complex/CGAL/Cell_attribute_with_point.h:13: warning: explicit link request to 'Tag_true' could not be resolved
/home/runner/work/cgal/cgal/Linear_cell_complex/doc/Linear_cell_complex/CGAL/Cell_attribute_with_point_and_id.h:13: warning: explicit link request to 'Tag_true' could not be resolved
/home/runner/work/cgal/cgal/Linear_cell_complex/doc/Linear_cell_complex/CGAL/Cell_attribute_with_point_and_id.h:13: warning: explicit link request to 'Tag_false' could not be resolved
/home/runner/work/cgal/cgal/Linear_cell_complex/doc/Linear_cell_complex/CGAL/Cell_attribute_with_point_and_id.h:13: warning: explicit link request to 'Tag_true' could not be resolved
/home/runner/work/cgal/cgal/Number_types/doc/Number_types/CGAL/Sqrt_extension.h:84: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
/home/runner/work/cgal/cgal/Number_types/doc/Number_types/CGAL/Sqrt_extension.h:86: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
/home/runner/work/cgal/cgal/Number_types/doc/Number_types/CGAL/Sqrt_extension.h:105: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
/home/runner/work/cgal/cgal/Number_types/doc/Number_types/CGAL/Sqrt_extension.h:106: warning: unable to resolve link to 'CGAL::Tag_false' for \link command
/home/runner/work/cgal/cgal/Polygon_mesh_processing/include/CGAL/Rigid_triangle_mesh_collision_detection.h:56: warning: unable to resolve link to 'Tag_true' for \link command
/home/runner/work/cgal/cgal/Polygon_mesh_processing/include/CGAL/Rigid_triangle_mesh_collision_detection.h:57: warning: unable to resolve link to 'Tag_false' for \link command
[generated]:-1: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
[generated]:0: warning: unable to resolve link to 'CGAL::Tag_false' for \link command
/home/runner/work/cgal/cgal/Voronoi_diagram_2/doc/Voronoi_diagram_2/Voronoi_diagram_2.txt:295: warning: unable to resolve link to 'CGAL::Tag_true' for \link command
/home/runner/work/cgal/cgal/Voronoi_diagram_2/doc/Voronoi_diagram_2/Voronoi_diagram_2.txt:296: warning: unable to resolve link to 'CGAL::Tag_false' for \link command

https://github.com/CGAL/cgal/actions/runs/23246576316

@afabri
Copy link
Member

afabri commented Mar 18, 2026

It would be good practice to run doxygen locally (not directly but activating documentation generation in cmake .. and make doc)

@afabri
Copy link
Member

afabri commented Mar 18, 2026

Have a look at the Doxyfile.in of the Polygon Mesh Processing package to see how to handle some doxygen in directory doc some in include

@sainathmanda7
Copy link
Author

@afabri Thanks for pointing me to that example! I’ve updated Doxyfile.in for the STL_Extension package to include tags.h in the INPUT list, which should fix the documentation generation. Let me know if this looks good or if any further changes are needed.

@afabri
Copy link
Member

afabri commented Mar 18, 2026

Hello @sainathmanda7,
What motivates you to do such a pull request? The thing is that the documentation must be moved for an entire package and not just for a file, and no longer a low hanging fruit.
If it is for positioning yourself for the GSoC, this makes no sense. Choose a topic, convince the mentor that you are the right person for the task, produce a work plan.
Best,
Andreas

@sainathmanda7
Copy link
Author

Am sorry and Thankyou for your advice sir,
I will reach out to the relevant mentors with a proper work plan soon.

Thankyou sir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the documentation of <CGAL/tags.h> seems wrong, and should use the header file as the source for Doxygen.

2 participants