Fix copy-paste errors in compile_shaders() error messages and comments#9393
Open
RajdeepKushwaha5 wants to merge 1 commit intoCGAL:mainfrom
Open
Conversation
Fix 6 copy-paste errors in Basic_viewer.h compile_shaders() that were carried over from the clipping plane shader section: - Fix 4 incorrect error messages that say 'clipping plane' instead of the actual shader name (sphere, cylinder, normal, triangle) - Remove stale '// clipping plane shader' comment in the cylinder block - Fix wrong '// Normal shader' section comment on the triangle block Fixes CGAL#9392
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes misleading compile_shaders() debug output and section comments in Basic_viewer so shader compilation/linking failures are attributed to the correct shader blocks (per issue #9392).
Changes:
- Corrected 4 fragment-shader failure messages to reference sphere/cylinder/normal/triangle instead of “clipping plane”.
- Removed a stale “clipping plane shader” comment that was incorrectly placed in the cylinder shader block.
- Corrected the section header comment for the triangle shader block.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fix 6 copy-paste errors in
Basic_viewer/include/CGAL/Qt/Basic_viewer.hcompile_shaders()that were carried over from the clipping plane shader section when the sphere, cylinder, normal, and triangle shader blocks were added:4 incorrect error messages — the fragment shader
std::cerrmessages for sphere (line 989), cylinder (line 1022), normal (line 1054), and triangle (line 1086) all incorrectly said"Adding fragment shader for clipping plane FAILED"instead of naming the actual shader. Fixed each to reference the correct shader name.1 stale comment — line 997 had
// clipping plane shaderat the start of the Cylinder shader block. Removed it.1 wrong section comment — line 1059 had
// Normal shaderas the section header for the Triangle shader block. Changed to// Triangle shader.Release Management
Basic_viewer