Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new CLI command ("charsets") to list all supported charsets and updates existing commands and configuration to use the new charsets API.
- Updated charset specifications in config, fold, graph, and unfold commands to reference the new charsets package.
- Added the new "charsets" command to list available charset options.
- Introduced a charsets package implementation to centralize charset lookups and listing.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/appli/config/model_test.go | Updated charset usage in tests to use the new charsets constant. |
| internal/appli/config/model.go | Replaced charmap lookup loop with a call to charsets.Get for clarity. |
| internal/appli/command/unfold.go | Updated charset defaults to use new charsets constant. |
| internal/appli/command/root.go | Added a call to register the new charsets command. |
| internal/appli/command/graph.go | Updated charset reference in schema compilation to use charsets. |
| internal/appli/command/fold.go | Replaced charmap constant with charsets constant for consistency. |
| internal/appli/command/charsets.go | Introduced the new "charsets" command to list all supported charsets. |
| internal/appli/charsets/list.go | Added a package managing charset constants, listing, and lookups. |
Comments suppressed due to low confidence (1)
internal/appli/command/charsets.go:51
- [nitpick] The use of the identifier 'charsets' in this file both as an imported package and as a local variable in NewCharsetsCommand may lead to confusion. Consider renaming the local variable (e.g., 'cmdInstance') to clearly distinguish it from the imported package.
for _, charset := range charsets.List() {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.