feat: configure record feedback from yaml #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a configurable feedback mechanism for records by adding a new feedback flag in the schema and propagating it through record creation, build, and YAML configuration.
- Introduced a new boolean feedback field to node, record, and object structures.
- Added a new Feedback() option and corresponding setter methods.
- Extended YAML config and tests to support setting feedback.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/posimap/core/schema/node.go | Added feedback field with default false and new Feedback() option |
| pkg/posimap/core/schema/build.go | Propagates node feedback to record object |
| pkg/posimap/core/record/object.go | Expanded record object to include a feedback flag |
| internal/appli/config/model.go | Updated YAML config models to include a new feedback option |
| internal/appli/config/load_test.go | Added test case for feedback in YAML configuration |
| internal/appli/config/load.go | Modified include resolver to set default feedback to true if not provided |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.