Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an issue where a buffer that is too short now correctly triggers a failure. The key changes include:
- Adding a new error variable (ErrIncompleteBuffer) and updating the buffer growth function to detect incomplete buffers.
- Tweaking error messages in the unfold command for improved clarity.
- Refactoring the fold command to delegate the execution loop into a new helper function (execUntilEOF) to better handle EOF and error propagation.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/posimap/core/buffer/buffer.go | Added a new error for incomplete buffers and updated growTo for stricter read length checks. |
| internal/appli/command/unfold.go | Updated error messages for buffer preparation for consistency. |
| internal/appli/command/fold.go | Refactored the record handling loop into execUntilEOF and updated error handling. |
Comments suppressed due to low confidence (1)
internal/appli/command/fold.go:85
- [nitpick] Consider using a consistent variable name for the record object; currently, the call uses 'record' while the execUntilEOF function defines the parameter as 'rcrd'.
if err := f.execUntilEOF(cfg, reader, writer, record); err != nil {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.