feat: configure records separator #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new records separator configuration and updates buffer handling to support locking based on a separator. Key changes include:
- Adding a new "locked" flag and separator handling to the Buffer struct and its methods.
- Updating the Buffer interface and configuration model to accept a separator.
- Refactoring the unfold and fold commands to use the new separator logic.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/posimap/core/buffer/buffer.go | Adds separator-based locking in buffer operations and updates Reset. |
| pkg/posimap/api/buffer.go | Updates the Buffer interface to include a separator parameter and a Fill method. |
| internal/appli/config/model.go | Introduces a new Separator field to the configuration model. |
| internal/appli/command/unfold.go | Refactors record creation and buffer resetting logic with separator support. |
| internal/appli/command/fold.go | Adapts fold command to use the new separator behavior. |
| internal/appli/charsets/utils.go | Adds helper functions for charset encoding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.