Skip to content

Conversation

@adrienaury
Copy link
Member

No description provided.

@adrienaury adrienaury linked an issue Sep 10, 2025 that may be closed by this pull request
@adrienaury adrienaury requested a review from Copilot September 10, 2025 15:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements decimal separator localization for the COMP-3 codec, allowing users to use either dot (.) or comma (,) as decimal separators.

Key changes:

  • Added configurable decimal separator parameter to COMP-3 codec
  • Implemented dual input acceptance (both . and , separators) during encoding
  • Added CLI flags to control output decimal separator format

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkg/posimap/core/codec/comp3.go Added sep field to Comp3 struct and modified constructor to accept decimal separator parameter
pkg/posimap/core/codec/comp3_test.go Updated test cases to include separator parameter and added test for different separator
internal/appli/config/model.go Added Decimal field to Field struct and helper functions for dot/comma defaults
internal/appli/command/fold.go Added usecomma CLI flag and integrated decimal separator configuration
internal/appli/command/unfold.go Added usecomma CLI flag and integrated decimal separator configuration
internal/appli/command/testdata/fold/13-comp3.yaml Updated test configuration to use comma separator flag
internal/appli/command/testdata/fold/13-comp3/stdout.jsonl Updated expected output to use comma separators
internal/appli/command/testdata/unfold/13-comp3/stdin.jsonl Updated test input to include comma separators
README.md Updated documentation to describe decimal separator behavior
CHANGELOG.md Added changelog entries for the new feature

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@adrienaury adrienaury merged commit aeb4a34 into main Sep 10, 2025
1 check passed
@adrienaury adrienaury deleted the feat-comp-3-separator branch September 10, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: configure comp-3 decimal separator

2 participants