Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests.extra/regress-double_ref_shared #461

Merged
merged 2 commits into from
Feb 21, 2025
Merged

tests.extra/regress-double_ref_shared #461

merged 2 commits into from
Feb 21, 2025

Conversation

nwf
Copy link
Member

@nwf nwf commented Feb 20, 2025

This currently fails to link with...

/cheri/out/cheriot/sdk/bin/ld.lld -n --script=../../../../../build/cheriot/cheriot-rtos/regress-double/build.sonata/top_compartment-firmware.ldscript --relax -o ../../../../../build/cheriot/cheriot-rtos/regress-double/build.sonata/cheriot/cheriot/release/top_compartment --compartment-report=../../../../../build/cheriot/cheriot-rtos/regress-double/build.sonata/cheriot/cheriot/release/top_compartment.json ../../../../../build/cheriot/cheriot-rtos/regress-double/build.sonata/.objs/cheriot.loader/cheriot/cheriot/release/__/__/sdk/core/loader/boot.S.o ../../../../../build/cheriot/cheriot-rtos/regress-double/build.sonata/.objs/cheriot.loader/cheriot/cheriot/release/__/__/sdk/core/loader/boot.cc.o ../../../../../build/cheriot/cheriot-rtos/regress-double/build.sonata/.objs/cheriot.switcher/cheriot/cheriot/release/__/__/sdk/core/switcher/entry.S.o ../../../../../build/cheriot/cheriot-rtos/regress-double/build.sonata/cheriot/cheriot/release/atomic1.library ../../../../../build/cheriot/cheriot-rtos/regress-double/build.sonata/cheriot/cheriot/release/atomic4.library ../../../../../build/cheriot/cheriot-rtos/regress-double/build.sonata/cheriot/cheriot/release/cheriot.allocator.compartment ../../../../../build/cheriot/cheriot-rtos/regress-double/build.sonata/cheriot/cheriot/release/compartment_helpers.library ../../../../../build/cheriot/cheriot-rtos/regress-double/build.sonata/cheriot/cheriot/release/locks.library ../../../../../build/cheriot/cheriot-rtos/regress-double/build.sonata/cheriot/cheriot/release/cheriot.token_library.library ../../../../../build/cheriot/cheriot-rtos/regress-double/build.sonata/cheriot/cheriot/release/crt.library ../../../../../build/cheriot/cheriot-rtos/regress-double/build.sonata/cheriot/cheriot/release/debug.library ../../../../../build/cheriot/cheriot-rtos/regress-double/build.sonata/cheriot/cheriot/release/freestanding.library ../../../../../build/cheriot/cheriot-rtos/regress-double/build.sonata/cheriot/cheriot/release/top.compartment ../../../../../build/cheriot/cheriot-rtos/regress-double/build.sonata/cheriot/cheriot/release/top_compartment.scheduler.compartment
ld.lld: error: ../../../../../build/cheriot/cheriot-rtos/regress-double/build.sonata/cheriot/cheriot/release/top.compartment:(function top2(): .text+0x26): relocation against symbol __import_cheriot_shared_object_foo_true_false_false_false which is not defined

FWIW, top1.cc.o contains

00000000 g     O .compartment_imports.foo       00000008 __import_cheriot_shared_object_foo_true_true_false_false

and top2.cc.o contains

00000000 g     O .compartment_imports.foo       00000008 __import_cheriot_shared_object_foo_true_false_false_false

nwf added 2 commits February 21, 2025 15:22
@nwf
Use correct COMDAT name for manual cap import
20b6ee0 
In the case of shared objects, the name is that of the object, as
defined in the xmake configuration, but the mangled name includes the
permission vector, and is the approprite deduplication key.
@nwf
tests.extra/regress-double_ref_shared
85509fa
@nwf nwf force-pushed the nwf/202502-regress-double_ref_shared branch from 0e2c1e6 to 85509fa Compare February 21, 2025 15:32
@nwf nwf merged commit 092a41b into main Feb 21, 2025
7 checks passed
@nwf nwf deleted the nwf/202502-regress-double_ref_shared branch February 21, 2025 16:45
nwf added a commit to CHERIoT-Platform/cheriot-demos that referenced this pull request Feb 21, 2025
@nwf
Monolithic build
dfc6fd1 
Works after CHERIoT-Platform/cheriot-rtos#461
rmn30 pushed a commit to CHERIoT-Platform/cheriot-demos that referenced this pull request Feb 24, 2025
@nwf @rmn30
Monolithic build
2f6180c 
Works after CHERIoT-Platform/cheriot-rtos#461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidchisnall davidchisnall davidchisnall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nwf @davidchisnall