Small improvements to the token APIs. #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidchisnall
force-pushed
the
token-cleanup
branch
from
2ea10ea to
47cfe46
Compare
nwf
reviewed
Feb 20, 2025
Expose `token_unseal` as the type-safe wrapper for everything (C macro, C++ templated function). Make `token_allocate` not use the `Sealed` wrapper when it's not needed. The macro currently triggers a compiler bug.
davidchisnall
force-pushed
the
token-cleanup
branch
from
47cfe46 to
ecf903b
Compare
nwf
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose
token_unsealas the type-safe wrapper for everything (C macro, C++ templated function). Maketoken_allocatenot use theSealedwrapper when it's not needed.The macro currently triggers a compiler bug.