Python3 support in Lascar temp and humidity driver #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ejler
requested changes
Nov 4, 2019
Member
Ejler
left a comment
Ejler
left a comment
There was a problem hiding this comment.
I noticed that a useful ImportError is hidden if you've installed 'hid', but not one of the required backends to hid. It might be useful to reraise this error message since the script will crash anyway if hid is not properly imported. Otherwise it looks fine. I wouldn't mind it being Python3-only, but if both are supported I see no reason to change that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a somewhat clumsy but functionel Python3 (on top of Python2) support for this driver. The device in question is a small USB-pen based temperature and humidity and sensor. I don't know if it is even in use at CINF anymore, which may mean that the right move really is to make it Python3 only. If that is what you prefer, let me know and I will fix it.