2.11.4: adopt ciris-client 0.5.219 (CIRISClient#53) - #1169
Open
emooreatx wants to merge 1 commit into
Open
Conversation
… 2.11.4 0.5.219's one product change is the desktop's existing-backend probe: it now asks both readiness endpoints (agent :8080, node :4243) and treats any answer -- 4xx/5xx included -- as PRESENT, so a live backend is attached to rather than doubled, and the #40 message no longer tells a user to kill -9 an agent that was answering all along. It does NOT carry CIRISClient#54: the desktop still builds its ordinary API client from CIRIS_NODE_URL alone (default :4243). That path is closed on our side by 2.11.3's launcher, which sets CIRIS_NODE_URL to the brain -- the configuration the gate always ran and the product never did. All other pin sites (Gradle, the .aar fetch, the vendored JAR) derive from this one requirements.txt line. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J45bNgkggVC1ntnmp6DqQA
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins ciris-client 0.5.219 (
007f00f, tagv0.5.219, published to PyPI in run 34527118549). Every other pin site — Gradle, the.aarfetch, the vendored desktop JAR — derives from the onerequirements.txtline.What .219 carries — CIRISClient#53. The desktop's existing-backend probe now asks both readiness endpoints (agent
:8080, node:4243) and treats any answer, 4xx/5xx included, asPRESENT: a live backend is attached to instead of doubled, and the #40 message no longer tells a user tokill -9an agent that was answering.What it does not carry — CIRISClient#54. The desktop still builds its ordinary API client from
CIRIS_NODE_URLalone (default:4243), so a JAR launched with onlyCIRIS_API_URL404s on every brain-only route. That is closed on our side by 2.11.3 (#1168): the launcher setsCIRIS_NODE_URLto the brain, the configuration the gate always ran and the product never did. The Windows user's "404 on Add provider" is that, not #53.Version 2.11.3 → 2.11.4.
check_version_alignment.pygreen.Note for the five-platform gate: the iOS xcframework for .219 was still building when this opened; the gate's iOS leg needs it.
🤖 Generated with Claude Code
https://claude.ai/code/session_01J45bNgkggVC1ntnmp6DqQA