-
Notifications
You must be signed in to change notification settings - Fork 6
Burn lstm and Boost update #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR synchronizes the Singularity build definition with the latest Docker container changes, focusing on three main updates: updating to Burn LSTM implementation, upgrading Boost from 1.79.0 to 1.86.0, and adding test coverage for LSTM functionality.
Key changes:
- Upgraded Boost library from version 1.79.0 to 1.86.0 with optimized build (headers-only)
- Added rust-lstm-1025 build and integration with automatic weight conversion
- Enhanced test suite to include LSTM-specific validation using a new test directory
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| singularity/singularity_ngen.def | Updated build process with Boost 1.86.0, refactored UV and Python environment setup, added rust-lstm build steps with weight conversion, and improved build efficiency with globstar patterns and wheel caching |
| .github/workflows/singularity_image.yml | Extended test coverage to include LSTM model validation by adding a second test directory and improving test robustness with better error handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arpita0911patel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix copilot suggestions on this PR.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
@arpita0911patel |
|
@JoshCu |
This update sync to docker commit.