Skip to content

Conversation

@benlee0423
Copy link
Contributor

@benlee0423 benlee0423 commented Nov 10, 2025

This update sync to docker commit.

  1. Update docker change Burn lstm
  2. Update Boost to 1.86
  3. Add test for lstm image.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR synchronizes the Singularity build definition with the latest Docker container changes, focusing on three main updates: updating to Burn LSTM implementation, upgrading Boost from 1.79.0 to 1.86.0, and adding test coverage for LSTM functionality.

Key changes:

  • Upgraded Boost library from version 1.79.0 to 1.86.0 with optimized build (headers-only)
  • Added rust-lstm-1025 build and integration with automatic weight conversion
  • Enhanced test suite to include LSTM-specific validation using a new test directory

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
singularity/singularity_ngen.def Updated build process with Boost 1.86.0, refactored UV and Python environment setup, added rust-lstm build steps with weight conversion, and improved build efficiency with globstar patterns and wheel caching
.github/workflows/singularity_image.yml Extended test coverage to include LSTM model validation by adding a second test directory and improving test robustness with better error handling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@arpita0911patel arpita0911patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix copilot suggestions on this PR.

@benlee0423
Copy link
Contributor Author

@arpita0911patel
Fixed copilot suggestions. Feel free to review again and merge.

@benlee0423
Copy link
Contributor Author

@JoshCu
Please review.

@benlee0423 benlee0423 merged commit 2fa32cc into main Nov 24, 2025
2 of 3 checks passed
@benlee0423 benlee0423 deleted the Oct-release branch November 24, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants