Final 0.3.0 #36
Open
Final 0.3.0 #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ateral Increased the speed by about 5 times for Forcing Array Construction
…lateral of the nexus is passed to downstream flowline. crosswaslking nexus, poi is also done if the qlateral_input files is channel routing, then it follows old convention of routing. added multiprocessing in reading channel routing files which helps to create lateral array 5 times faster headwater routing needs to be done with interpolation
Removed flowpath attributes manually if the network type is NHD
…ature_id as index in other file types
… into terminal nexus Fixed f-string formatting descriptive dictionary variable
…etwork_bodies parameter is. But I think the better way to do this in Hyfeature implementation is to seperate the creation of lake_gage_df from the normal gage dataframe because creation of lake_gage_df should certainly depend on break_network_waterbody, and that's how NHD functions.
… updates:1)Got rid of the idea of giuh parameter\n2)If using hyfeature network only accept output from nextgen with file pattern nex-* cat-*\n3)No headwater routing for now (but the function that maps pseudo headwaters to its first nexus' downstream still exists\n4)Cleaned up a lot so should be ready to merge after some review
quinnylee
reviewed
Nov 10, 2025
quinnylee
requested changes
Nov 10, 2025
quinnylee
reviewed
Nov 10, 2025
quinnylee
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new pull request makes t-route compatible with hydriofabric version 3.0. Also, this includes the new routing algorithm where the lateralflow stored in nexus gets mapped to the flowpath/flowline downstream to nexus. This PR gets rid of the idea of giuh node. It also makes user to strictly use nextgen output if using Hyfeature network. This doesn't include the routing of pseudo-headwater catchments. Finally, everything is cleaned up, so this should be ready to merged after a review.