Skip to content

Christopher Yuen Lab2 Submission #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cj-yuen wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Christopher Yuen Lab2 Submission #12

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d57c704
Document debugging process and bug fixes in README
cj-yuen Sep 17, 2025
aac57e8
Update README with partner details and Shadertoy link
cj-yuen Sep 17, 2025
85acd47
Fix partner line formatting in README.md
cj-yuen Sep 17, 2025
0e4ce68
Fix formatting and update partner information in README
cj-yuen Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,16 @@ It don't do that. Correct THREE of the FIVE bugs that are messing up the output.

Extra credit if you can find all FIVE bugs.

# Debugs
1) In mainImage() we never call uv2 so I just replaced 'vec uv2 = ...' with 'uv = ...' to fix the black screen.
2) In raycast(), we horizontal scale is messed up as it was 'iResolution.x / iResolution.x' which I fixed with 'iResolution.x / iResolution.y' which is the correct horizontal screen ratio.
3) In sdf3d(), to apply specular, we need to replace 'dir = reflect(eye, nor);' with 'dir = reflect(dir, nor);'.
4) In march(), to fix the floor not extending out as far as we want, change the value that i goes till. I replaced 'i < 64' with 'i < 200'. This also gets rid of the weird warping around the spheres.
5)

Partner: Marcus <br>
Shadertoy: https://www.shadertoy.com/view/wcsfWf

# Submission
- Create a pull request to this repository
- In the README, include the names of both your team members
Expand Down