Fix: Add questionaire IDs, clean the deletion#105
Open
artikandri wants to merge 3 commits intofeature/DynamicAnnotationProjectfrom
Open
Fix: Add questionaire IDs, clean the deletion#105artikandri wants to merge 3 commits intofeature/DynamicAnnotationProjectfrom
artikandri wants to merge 3 commits intofeature/DynamicAnnotationProjectfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues fixed with this PR:
Some of the przed_i_po_badaniu questionnaires are deleted but they still exist in the settings, so this PR deleted those in the settings as well. The incomplete deletion may cause users who has not finished their questionnaires before deletion to get prompts to finish the inexist questionnaires forever, which is quite minor, but might annoy users.
As for now this PR might not be needed, but should there be problems with the przed_i_po_badaniu questionnaire, this PR might fix it. It may also serve as documentation.
What's changed:
frontend/components/auth/FormLogin.vue: added more time to set filled questionnairesfrontend/components/questionnaires/form/SliderInput.vue: fix alignment warnings, which may appear onconsolewhen we are running the code onyarn devfrontend/pages/questionnaires/*/js/questionnaires.js: added the idsfrontend/utils/questionnaires.js: deleted the deleted questionnaire ids from the questionnaire settings