Automatic retry logic - #122
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds automatic retry behavior to the Python Onyx client so transient gateway/service failures (502/503/504) are retried with exponential backoff, addressing #121.
Changes:
- Configure a
requests.Sessionwith anHTTPAdapter+Retrystrategy and use it both inside and outside the client context manager. - Add unit tests asserting retry adapter configuration and verifying retry behavior.
- Add
responsesto thedev/testoptional dependency groups.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
onyx/core.py |
Introduces retry constants and configures a retry-enabled requests.Session; updates context manager behavior to use the configured session. |
tests/test_api.py |
Adds tests to validate retry configuration and runtime retry behavior. |
pyproject.toml |
Adds responses as a test/dev dependency to support the new retry tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
502,503and504.