Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes continuous optimization functionality from the codebase and deprecates related APIs in favor of an external package. It also updates documentation and project configuration to reflect this change, and introduces a new GitHub Actions workflow for notebook testing.
Deprecation and removal of continuous optimization:
optimizefunction and all related code (including parameter conditioning and progress tracking) have been removed fromsrc/jax_grid_search/_optimizers.py. Instead, a stub remains that raisesNotImplementedErrorand instructs users to usefurax_cs.minimizefrom thefurax-cspackage.conditionfunction anddefault_desc_cbhave been removed from the public API insrc/jax_grid_search/__init__.py, and documentation now marksoptimizeas deprecated. [1] [2]examples/README.md. [1] [2] [3] [4]optax,optimistix,lineax,equinox, andjax-progress) have been removed frompyproject.toml. [1] [2]Testing and documentation improvements:
.github/workflows/notebooks.yml) has been added to automatically execute all example notebooks across multiple Python versions and upload the outputs as artifacts.README.mdhas been updated to add a badge for the new notebooks workflow and clarify the naming of the tests badge.