Skip to content

Comments

NDH-565: Implementing collecting traces and sending to Datadog#368

Merged
dmtrscms merged 10 commits intomainfrom
datadog-integration
Feb 18, 2026
Merged

NDH-565: Implementing collecting traces and sending to Datadog#368
dmtrscms merged 10 commits intomainfrom
datadog-integration

Conversation

@dmtrscms
Copy link
Contributor

@dmtrscms dmtrscms commented Jan 27, 2026

module-name: Updating to add in Datadog integration

Jira Ticket #NDH-565

Problem

We need to start sending trace information from API usage to Datadog

Solution

Updated files to install the python module for Datadog, updated the docker compose file to install the Datadog agent, and provided the necessary configuration for trace information to be sent to Datadog.

Result

API related trace information is sent to Datadog.

Some important notes regarding the summary line:

  1. Updating Dockerfile to run the Datadog trace command
  2. Installing the Datadog module
  3. Creating a container for the Datadog agent
  4. Creating environment variables and labels to configure access and parsing of trace information.

Test Plan

Work with @blaine to adapt this to use the AWS container definition. These changes only work locally.

Copy link
Contributor

@rmillergv rmillergv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI Demetrius,

two requests, how do other people get the Datadog API key? Can we put that up in AWS secrets please (and put instructions here how to get the API key)

and,

it doesn't have to be exact, but please fill in at least some of thiis PR template

Thanks!

module-name: One line description of your change (less than 72 characters)
Jira Ticket
Problem
Explain the context and why you're making that change. What is the problem
you're trying to solve? In some cases there is not a problem and this can be
thought of being the motivation for your change.

Solution
Describe the modifications you've done.

Result
What will change as a result of your pull request? Note that sometimes this
section is unnecessary because it is self-explanatory based on the solution.

Some important notes regarding the summary line:

Describe what was done; not the result
Use the active voice
Use the present tense
Capitalize properly
Do not end in a period — this is a title/subject
Prefix the subject with its scope
Test Plan
(Write your test plan here. If you changed any code, please provide us with
clear instructions on how you verified your changes work.)

@dmtrscms
Copy link
Contributor Author

dmtrscms commented Jan 28, 2026 via email

@wbprice
Copy link
Collaborator

wbprice commented Feb 3, 2026

@dmtrscms how did you validate that this is working locally? I'm mostly seeing a bunch of certificate errors when trying to test this.

image

@dmtrscms
Copy link
Contributor Author

dmtrscms commented Feb 3, 2026

@dmtrscms how did you validate that this is working locally? I'm mostly seeing a bunch of certificate errors when trying to test this.

image

I spun up a local instance of the NPD app, made the modifications, hit the API, then looked at the Datadog dashboard.

I saw the traces and even saw which SQL statements got executed.

Copy link
Contributor

@rmillergv rmillergv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not run into a dev shop yet that did not love datadog.
Impact is usually negligible on compute time, and in our existing environment is not likely to be noticed at all.

@rmillergv
Copy link
Contributor

key is in AWS secrets: arn:aws:secretsmanager:us-east-1:575012135727:secret:npd-east-dev-datadog-api-key20260122173510575000000001-aT7ojn

this is the key for dev (nonprod).

@wbprice

@dmtrscms dmtrscms merged commit 24e39ba into main Feb 18, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants