Reduce duplication in the view queryset code#377
Merged
spopelka-dsac merged 3 commits intomainfrom Jan 30, 2026
Merged
Conversation
wbprice
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
module-name: Reduce duplication in the view queryset code
Jira Ticket
Problem
We had our view querysets defined independently for our
list()andretrieve()view methods, which made it harder to maintain the code, ensure consistency, and identify room for improvement from a performance standpoint.Solution
This PR pulls all the queryset logic into a class attribute that is referenced by the
list()andretrieve()methods, so the code for each view only needs to be maintained in one place. For clarity and consistency, this PR also moves the order by logic to theorderingclass attribute.These changes make it easier to understand and maintain the code, which in turn makes it easier to perform performance improvements and future code updates.
Test Plan
All tests should pass