[NDH-811] Fix Bug with Zip Code Filters Leading Zero#386
Merged
spopelka-dsac merged 14 commits intomainfrom Feb 11, 2026
Merged
[NDH-811] Fix Bug with Zip Code Filters Leading Zero#386spopelka-dsac merged 14 commits intomainfrom
spopelka-dsac merged 14 commits intomainfrom
Conversation
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
…ts accordingly Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
IsaacMilarky
requested review from
rmillergv,
sachin-panayil,
spopelka-dsac and
wbprice
as code owners
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
…com:CMS-Enterprise/npd into isaacmilarky/NDH-811-zipcode-filter-bug-fix
Collaborator
sachin-panayil
left a comment
sachin-panayil
left a comment
There was a problem hiding this comment.
lgtm! pulled, ran and tested
spopelka-dsac
requested changes
Feb 6, 2026
Contributor
spopelka-dsac
left a comment
spopelka-dsac
left a comment
There was a problem hiding this comment.
Looks great! Just a few notes on tests
added 3 commits
February 9, 2026 09:54
Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov>
Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov>
Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov>
added 4 commits
February 11, 2026 10:44
Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov>
Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov>
Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov>
spopelka-dsac
approved these changes
Feb 11, 2026
spopelka-dsac
deleted the
isaacmilarky/NDH-811-zipcode-filter-bug-fix
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
module-name: One line description of your change (less than 72 characters)
Jira Ticket #NDH-811
Problem
There is a bug with the behavior of zip code filters in the api where it ignores leading zeroes. This is a problem since many zip codes start with 0.
Solution
Change the full address filter to use SearchQuery with "websearch" to avoid issues with postgres tokenization. Also just use a direct filter match on the filter that just checks zipcode.
Result
Summary:
Test Plan
Run new tests that test leading zeroes.