Skip to content

Comments

[NDH-806] Updating Dev Onboarding #388

Merged
sachin-panayil merged 8 commits intomainfrom
sachin/ndh-806-updating-dev-onboarding
Feb 10, 2026
Merged

[NDH-806] Updating Dev Onboarding #388
sachin-panayil merged 8 commits intomainfrom
sachin/ndh-806-updating-dev-onboarding

Conversation

@sachin-panayil
Copy link
Collaborator

@sachin-panayil sachin-panayil commented Feb 6, 2026

Updating Dev Onboarding

Jira Ticket #806

Problem

There was some onboarding issues when a new engineer attempted to onboard to the NPD repo from scratch.

  1. Python dependency blocked some code from running improperly
  2. Mismatch of docker volumes library version
  3. No troubleshooting guide

Solution

  1. Add a dependency section in the documentation
  2. Add a new flyway migration that mitigates the following. Read the the thread from this message onwards
  3. Add a troubleshooting guide

Result

The engineer onboarding flow for getting NPD up and running for a brand new dev should be easier now.

Some important notes regarding the summary line:

  • We should prob dockerize the dependency stuff in the future but will leave that for a future day

Test Plan

  • run make up
  • run make test
  • run make test-server
  • run make playwright

@sachin-panayil sachin-panayil changed the title Sachin/ndh 806 updating dev onboarding [NDH-806] Updating Dev Onboarding Feb 6, 2026
@sachin-panayil sachin-panayil self-assigned this Feb 6, 2026
@sachin-panayil sachin-panayil marked this pull request as ready for review February 6, 2026 21:29
@sachin-panayil sachin-panayil enabled auto-merge (squash) February 6, 2026 21:29
Copy link
Contributor

@spopelka-dsac spopelka-dsac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these improvements to the CONTRIBUTING doc! Just a few mods

Copy link
Contributor

@spopelka-dsac spopelka-dsac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two super minor changes, otherwise this is a super awesome addition to our dev onboarding resources!

Copy link
Contributor

@spopelka-dsac spopelka-dsac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one dependency for mac

Copy link
Contributor

@spopelka-dsac spopelka-dsac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also modded to remove your content about recreating the volume; recreating the volume isn't the move here, because we use local system dirs mounted to docker volumes, which docker doesn't have control over. Happy to talk through in more detail

@sachin-panayil sachin-panayil merged commit bb1d91d into main Feb 10, 2026
12 checks passed
@spopelka-dsac spopelka-dsac deleted the sachin/ndh-806-updating-dev-onboarding branch February 10, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants