Skip to content

Comments

[NDH-830] Update PractitionerRole Endpoint#389

Merged
spopelka-dsac merged 23 commits intomainfrom
sjp/update-practitionerrole
Feb 9, 2026
Merged

[NDH-830] Update PractitionerRole Endpoint#389
spopelka-dsac merged 23 commits intomainfrom
sjp/update-practitionerrole

Conversation

@spopelka-dsac
Copy link
Contributor

@spopelka-dsac spopelka-dsac commented Feb 6, 2026

module-name: [NDH-830] Update PractitionerRole Endpoint

Jira Ticket #NDH-830

Problem

As I was going through and working on performance improvements, I realized that we were not exposing endpoints at /fhir/PractitionerRole, which we needed to do. I also realized we still had a few tests that were not fully making the necessary assertions.

Solution

  • Add endpoint serialization to the PractitionerRoleSerializer
  • Improve practitioner role fixtures (and other test fixtures) to better generate the expected test data
  • Fix tests that were giving false negatives due to insufficient assertions and/or insufficient test data
  • Rename a couple of PractitionerRole filters to better align with the FHIR spec

Result

We now have endpoints at PractitionerRole! And we have more robust tests!
image

Test Plan

  • All tests should pass
  • run docker compose up --build and navigate to localhost:8000/fhir/PractitionerRole?endpoint_status=active to confirm that the "endpoint" attribute looks as expected. (note: not all practitioner role resources have endpoints associated with them, so the query param forces records that have endpoints to be shown)

NOTE: This PR should be merged after #385

@spopelka-dsac
Copy link
Contributor Author

NOTE: This PR should be merged after #385

@spopelka-dsac spopelka-dsac merged commit c620820 into main Feb 9, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants